fix test for parsing POD errors

metacpan · Apr 21, 2016 · 5f3d4fc · 5f3d4fc
1 parent 792c441
commit 5f3d4fc
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 3 deletions.
diff --git a/lib/MetaCPAN/Document/File.pm b/lib/MetaCPAN/Document/File.pm
@@ -160,17 +160,20 @@ sub _build_description {
         = MetaCPAN::Util::extract_section( ${ $self->content },
         'DESCRIPTION' );
     return undef unless ($section);
+
     my $parser = Pod::Text->new;
-    my $text   = "";
+    my $text   = q{};
     $parser->output_string( \$text );
 
     try {
         $parser->parse_string_document("=pod\n\n$section");
     }
     catch {
-        warn $_[0];
+        warn $_;
     };
 
+    return undef unless $text;
+
     $text =~ s/\s+/ /g;
     $text =~ s/^\s+//;
     $text =~ s/\s+$//;

diff --git a/t/document/file.t b/t/document/file.t
@@ -528,12 +528,13 @@ subtest 'pod parsing errors are not fatal' => sub {
 package Foo;
 use strict;
 
-=head1 NAME
+=head1 DESCRIPTION
 
 Foo - mymodule1 abstract
 POD
 
     no warnings 'redefine';
+
     local *Pod::Text::parse_string_document = sub {
         die "# [fake pod error]\n";
     };