Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

block comments proof of concept #2570

Closed
wants to merge 1 commit into from

Conversation

jkthorne
Copy link
Contributor

@jkthorne jkthorne commented May 7, 2016

I wanted to get some feedback on this before I got too far.
I feel like this is a pretty good proof of concept for a block commenting system

It would be something like this.

##
This is a note about this code
##

And for more formal comments related to documentation

##
# This is a formatted note
# Is is a pretty note
##

@kostya
Copy link
Contributor

kostya commented May 7, 2016

why not =begin =end?

@jkthorne
Copy link
Contributor Author

jkthorne commented May 7, 2016

I like syntax for commenting that is not dependent on words.
I added this to another projects and really loved it.

You can add formatted commenting with a gutter hash which is nice and visibly awesome in code.
Little side benefit you can turn a comment into a block comment easier.

For me this feels like a natural extension of commenting into block commenting.

Also as has been said throughout this project this is not Ruby so I did not see the need to just implement the same feature as ruby.

These are just some of my thoughts.
I would love feedback before finishing though.

@asterite
Copy link
Member

asterite commented May 8, 2016

Hi @Javajax,

This is actually a duplicate of #1401 (with a different syntax, but the reasons for not adding this to the language are the same)

@ozra
Copy link
Contributor

ozra commented May 8, 2016

I haven't stumbled upon a ("modern") editor yet where ctrl+3 won't comment/uncomment a selection. Single-line comments are much clearer, especially when some parts are "double commented" in wip-code. Multi-line comments has always been a nightmare in languages supporting them, in my opinion.

@jkthorne
Copy link
Contributor Author

jkthorne commented May 8, 2016

I actually think there is more to it then just the editor and I am glad to see another solution like this. Anyways I thought it was a good idea but I do agree with the general sentiment as well.

@jkthorne jkthorne closed this May 8, 2016
@jkthorne jkthorne deleted the block_comments branch May 23, 2017 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants