-
-
Notifications
You must be signed in to change notification settings - Fork 925
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
jruby-rack adjust_gem_path has no effect #3828
Comments
@mkristian very najs find! wonder if its worth the "startup cost" to issue a |
@kares did look a bit further and there is more then this commit to it. first I thought it is the |
sounds like a jruby.rack.gem.path env/web.xml setting would be necessary anyway? also this has other consequences to be considered - would anyone want "did_you_mean" to be "messing" on env.production? |
let's reduce the regression to a simple example:
and jruby-9.1.0.0-SNAPSHOT
|
for the record the other |
Tick tock gentlemen :-) |
What if we just make it try to |
the problem is that when require fails that rubygems will go though as @kares asked before where we need did_you_mean in production, i.e. for |
Yeah that is a pain...there's no good option. I see two paths forward:
I'm going to chat with @tenderlove today about options. |
We are going to punt this decision to 9.1.1.0. |
@mkristian Seems fine to me if they're passing. It's obviously something we'll have to deal with when we do get DYM in place. |
9.1.1.0 has become a quick regression-patching release, so bumped this to 9.1.2.0. |
already fixed with #3892 and travis |
Environment
when investigating the broken j2ee tests on travis it shows that the
ENV['GEM_PATH']
set by jruby-rack has no effect onGem.path
and so does not show up in the testcase.Expected Behavior
jruby does not call Gem.path before requiring a file outside the core.
Actual Behavior
which gets activated on jruby startup.
commit 4a8a2bc introduce this problem.
The text was updated successfully, but these errors were encountered: