-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unable to load EllipticalCurve EC class from JRuby's OpenSSL library [$500 awarded] #90
Comments
Upvoting: this is going to be necessary in order to encode payloads for the new Web Push API, for example with the webpush gem |
I know its not that much, but just posted a $100 bounty on this at BountySource if anyone is interested. @headius would it be possible to put a 'bounty' tag or label on the issue by any chance? (totally understandable if you don't want money influencing which bugs get fixed though, just a suggestion:) |
@mohamedhafez thanks. added a link to BountySource in the desc. also regarding the .rb impl - it wasn't working good enough would instead prefer to have a native Java impl. |
I'm fine adding a "bounty" tag if that's all that's required to integrate BountySource. |
@headius It looks like if you log into bountysource with a GitHub account that owns a project, you can turn on automatic integration that will automatically apply bountysource labels to issues and update bounty totals, etc: http://blog.bountysource.com/post/48954271533/improved-github-integration-automatically-update |
Since it looked like @kares was on board with Bountysource, I've enabled the automatic integration. It will be a good opportunity to evaluate it for other projects like JRuby. |
been looking into this for a few days now and have a prototype but all the details are turning out a bit hard to get right ;( esp. since there's little docs and one ends up looking into Ruby/OpenSSL internals. as I am not sure which details are more important over others I looked into @mohamedhafez's webpush use-case, which seems to only use symmetric encryption over EC. so I am willing to give that part some more hours if it's acceptable as a resolution to get that working. |
Personally as long as web push payload encryption works, I'm happy:) On Tuesday, May 31, 2016, Karol Bucek notifications@github.com wrote:
|
(symmetric) EC support just landed on master ... most of the w prefer having smaller focused issues on what's not working (users shall report) instead of this monolith. |
Awesome thanks so much for the quick fix @kares, this does everything I need:) |
Actually it looks like a future version of the Web Push API will encourage the use of VAPID, which requires ECDSA, I'm guessing that's the asymmetric signature/verification part you were mentioning. I'd be fine closing this issue (and delivering the bounty) and then opening a new issue for that if that's the case |
taking a closer look, I believe its just ECDSA signature that would be required for this use case |
@mohamedhafez thanks for the info, we're already half into 0.9.17 release (rushing due a leak) so the "non-future" parts of WebPush will be there. would be great if the existing EC/DH+GCM support was real-world tested. there's much work around jossl so I do not really have time for a test application. |
Sounds good to me, thanks again @kares. I'll start using it in my app and report back if I see any issues |
Just wanted to report back that I've been using the webpush gem along with this fix in my real-world app, and its been smooth sailing. (Though admittedly there hasn't been a huge usage of the webpush feature yet since my app is for subsititute teachers and this is the low season since its summer out here) |
(Transplanted from jruby/jruby#1261 reported by @michaelgpearce)
I hope this is the right place to report this bug (i think it is!).
The class OpenSSL::PKey::EC does not load on JRuby version 1.7.8. The library loads with the same commands in MRI version 1.9.3p125 and 2.0.0p195.
In MRI:
See comments in jruby/jruby#1261. We had hoped to fix this for JRuby 9.1, but it will probably not happen. Moving this to jruby-openssl since it needs to be handled on jruby-openssl's release cycle.
cc @kares @mkristian @enebo
Want to see this issue fixed? Post a bounty on it! We accept bounties via Bountysource.
--- The **[$500 bounty](https://www.bountysource.com/issues/33165948-unable-to-load-ellipticalcurve-ec-class-from-jruby-s-openssl-library?utm_campaign=plugin&utm_content=tracker%2F136995&utm_medium=issues&utm_source=github)** on this issue has been claimed at [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F136995&utm_medium=issues&utm_source=github).The text was updated successfully, but these errors were encountered: