libiconv: Correct cross-building #15021
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Select the crossDrv based on the target platform in all-packages.nix, remove superfluous assert in libiconv
|
By analyzing the blame information on this pull request, we identified @domenkozar, @vcunat and @edolstra to be potential reviewers |
|
Hmm, yes, I think so. Cross-compilation is still rather hacky, unfortunately. |
Not possible to cross-compile darwin.libiconv since it is a system library.
find-tarballs.nix was failing withing this fix
|
I've fixed the failure in CI call into find-tarballs.nix. Remaining is the failure in libiconvReal by the automatic dependency checker -- it should try to build this on a glibc system. How to proceed? |
7 tasks
rasendubi
added
the
6.topic: cross-compilation
|
I made similar changes to libiconv in my pull request here: #21388 |
|
As did I #21268. My or @DavidEGrayson's PRs should be merged in lieu of this. |
|
Closing in deference to the above mentioned PRs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)Select the crossDrv based on the target platform in all-packages.nix,
remove superfluous assert in libiconv
nix-shell -p nox --run "nox-review wip" fails because it tries to build libiconvReal on Linux which fails on master already