Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add perl access to pl_cmd and ability to set Cairo context #2

Closed
wants to merge 2 commits into from

Conversation

mikef5410
Copy link

With this patch we can set the cairo context, and therefore embed a plplot graphic in a Gtk3 widget.

@mohawk2
Copy link
Member

mohawk2 commented May 2, 2016

Just for starters, you need to git rm META.* :-)

@mohawk2
Copy link
Member

mohawk2 commented May 2, 2016

I see you have a number of (colossally large) files that seem to be demos, but are in the t directory? Surely that's not what you intend?

@mikef5410
Copy link
Author

Commit 905002 is the "interesting" change, and it only involves plplot.pd

Sorry, I don't see the big files you're talking about.

@mohawk2
Copy link
Member

mohawk2 commented May 3, 2016

Fair enough. If you look at this page, you will see large files. If you intend only to merge one commit, could you rebase and force-push your branch such that it's the only commit in this PR? Although that does beg the question as to why the author of the repo, Doug Hunt, isn't using this repo to track changes.

@mohawk2
Copy link
Member

mohawk2 commented May 3, 2016

In fact, I have emailed him to ask.

@zmughal
Copy link
Member

zmughal commented May 5, 2016

CC @doughunt.

@mohawk2
Copy link
Member

mohawk2 commented Dec 28, 2019

Hi @mikef5410, I've rebased this commit onto latest master. Since I don't have permission to force-push to your branch, I've pushed it to the CairoContext branch of this repo.

Is this change one you're still interested in? Would it make more sense to have it in a subclass of P::G::PLplot, in which case you could release it yourself? Also, if you are still interested, please write some tests for it :-)

@mikef5410
Copy link
Author

mikef5410 commented Dec 28, 2019 via email

@mohawk2
Copy link
Member

mohawk2 commented Dec 28, 2019

No need to make a second PR, you can use this one. All you need to do is:

git remote add upstream git@github.com:PDLPorters/pdl-graphics-plplot.git
git fetch --all
git checkout CairoContext
git reset --hard upstream/CairoContext
git push -f

which will switch you to my rebased version. Then you can add tests, and so on!

@mikef5410
Copy link
Author

mikef5410 commented Dec 28, 2019 via email

@mohawk2 mohawk2 force-pushed the master branch 3 times, most recently from cac2ceb to 4ca9fcf Compare July 29, 2021 03:09
@mohawk2
Copy link
Member

mohawk2 commented Jul 29, 2021

I have merged this change and released it as 0.76. There are no tests so there is no guarantee it works correctly.

@mohawk2 mohawk2 closed this Jul 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants