New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add perl access to pl_cmd and ability to set Cairo context #2
Conversation
Just for starters, you need to |
I see you have a number of (colossally large) files that seem to be demos, but are in the |
Commit 905002 is the "interesting" change, and it only involves plplot.pd Sorry, I don't see the big files you're talking about. |
Fair enough. If you look at this page, you will see large files. If you intend only to merge one commit, could you rebase and force-push your branch such that it's the only commit in this PR? Although that does beg the question as to why the author of the repo, Doug Hunt, isn't using this repo to track changes. |
In fact, I have emailed him to ask. |
CC @doughunt. |
Hi @mikef5410, I've rebased this commit onto latest master. Since I don't have permission to force-push to your branch, I've pushed it to the Is this change one you're still interested in? Would it make more sense to have it in a subclass of P::G::PLplot, in which case you could release it yourself? Also, if you are still interested, please write some tests for it :-) |
Yes, please. It is not special purpose and should go into the main product. I'll look into what can be tested and add to my Cairo context branch and ask for a second pull.
thanks!
-Mike
…On Dec 28, 2019, 12:13, at 12:13, mohawk2 ***@***.***> wrote:
Hi @mikef5410, I've rebased this commit onto latest master. Since I
don't have permission to force-push to your branch, I've pushed it to
the `CairoContext` branch of this repo.
Is this change one you're still interested in? Would it make more sense
to have it in a subclass of P::G::PLplot, in which case you could
release it yourself? Also, if you *are* still interested, please write
some tests for it :-)
--
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub:
#2 (comment)
|
No need to make a second PR, you can use this one. All you need to do is:
which will switch you to my rebased version. Then you can add tests, and so on! |
Cool. Will do. Thanks again.
…On Dec 28, 2019, 15:19, at 15:19, mohawk2 ***@***.***> wrote:
No need to make a second PR, you can use this one. All you need to do
is:
```
git remote add upstream
***@***.***:PDLPorters/pdl-graphics-plplot.git
git fetch --all
git checkout CairoContext
git reset --hard upstream/CairoContext
git push -f
```
which will switch you to my rebased version. Then you can add tests,
and so on!
--
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub:
#2 (comment)
|
cac2ceb
to
4ca9fcf
Compare
I have merged this change and released it as 0.76. There are no tests so there is no guarantee it works correctly. |
With this patch we can set the cairo context, and therefore embed a plplot graphic in a Gtk3 widget.