Make ALL cipher string match ECDHE ciphers #91
Merged
+44
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MRI includes ECDHE ciphers under the
ALL
cipher string and this replicates that behavior. This doesn't fully solve jruby/jruby#1774 but it at least makes ECDHE ciphers available underALL
. There are other issues withCipherStrings
(see: jruby/jruby#1738 (comment)) that need to be worked out, but this fixes my current use case.The following ciphers are added to the
ALL
cipher string:I also verified that no new ciphers were added that aren't already included by MRI