If a title has line breaks it messes up meta generation. #2330
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| # titles can have line breaks in them, particularly when they are | ||
| # created by third-party tools that post to Wordpress. | ||
| # Handle windows-style and unix-style line endings. | ||
| title = title.replace('\r\n', ' ').replace('\n') |
There was a problem hiding this comment.
missing the second argument to str.replace in the second call
|
Thanks for your contribution! |
Kwpolska
added a commit
that referenced
this pull request
May 4, 2016
Signed-off-by: Chris Warrick <kwpolska@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.