-
Notifications
You must be signed in to change notification settings - Fork 9
Comparing changes
Open a pull request
base repository: agdsn/sipa
base: 9bb2abbd2f40eba7a71352dbfafa7c882807ff36^
head repository: agdsn/sipa
compare: 0.2
Commits on Jan 25, 2016
-
Return KiB Values in the model
- Add a template filter and use it for the gauge - Return KiB in implemented models - Fix the tests accordingly Fix #157
Configuration menu - View commit details
-
Copy full SHA for 9bb2abb - Browse repository at this point
Copy the full SHA 9bb2abbView commit details
Commits on Feb 12, 2016
-
Configuration menu - View commit details
-
Copy full SHA for e4e4d71 - Browse repository at this point
Copy the full SHA e4e4d71View commit details -
Configuration menu - View commit details
-
Copy full SHA for 534ce04 - Browse repository at this point
Copy the full SHA 534ce04View commit details -
Tiny reformatting in message composition
No implementation change
Configuration menu - View commit details
-
Copy full SHA for 23e6f47 - Browse repository at this point
Copy the full SHA 23e6f47View commit details -
Configuration menu - View commit details
-
Copy full SHA for a8169e5 - Browse repository at this point
Copy the full SHA a8169e5View commit details -
Configuration menu - View commit details
-
Copy full SHA for e25846f - Browse repository at this point
Copy the full SHA e25846fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 05ca3f3 - Browse repository at this point
Copy the full SHA 05ca3f3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1c73195 - Browse repository at this point
Copy the full SHA 1c73195View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6b9c1f6 - Browse repository at this point
Copy the full SHA 6b9c1f6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3380cb7 - Browse repository at this point
Copy the full SHA 3380cb7View commit details
Commits on Feb 13, 2016
-
Disable
SQLALCHEMY_TRACK_MODIFICATIONS
This is just to avoid the warning. Track modifications don't affect us anyway, since they only apply when one wants to make use of tracking changes in the model. It will in future releases be disabled by default according to the warning.
Configuration menu - View commit details
-
Copy full SHA for 87b285a - Browse repository at this point
Copy the full SHA 87b285aView commit details -
Use a
dictConfig
instead of the old-style iniAdding an extra config in the ini style is still supported, but will be replaced by something better soon. Also, test `location_log_config` for None, because `isfile` does not accept `None` as a path. Refs #190
Configuration menu - View commit details
-
Copy full SHA for 1e521b9 - Browse repository at this point
Copy the full SHA 1e521b9View commit details
Commits on Feb 14, 2016
-
Configure sentry before the logging config
Sentry is now being initialized before the default and additional log configs are applied. This has the advantage that in the near future, when an additional `dict` config can be provided, such handlers can be added by will. Currently, only one `Sentry` instance is assumed, located at `app.extensions['sentry']`. Consequently, every `SentryHandler` returned by the handler-creating callable is linked to the latter. Making this possible required a small patch. See the docstring of `replace_empty_handler_callables`. Usage in a dict logging config: See `sipa.defaults.DEFAULT_CONFIG`. Refs #190
Configuration menu - View commit details
-
Copy full SHA for 35ce9e2 - Browse repository at this point
Copy the full SHA 35ce9e2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 486aa64 - Browse repository at this point
Copy the full SHA 486aa64View commit details -
This is a message concerning the initialization of the app. I think this better fits into the `DEBUG` layer.
Configuration menu - View commit details
-
Copy full SHA for e34db3f - Browse repository at this point
Copy the full SHA e34db3fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 500cadf - Browse repository at this point
Copy the full SHA 500cadfView commit details -
Configuration menu - View commit details
-
Copy full SHA for d09ec9e - Browse repository at this point
Copy the full SHA d09ec9eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 9392783 - Browse repository at this point
Copy the full SHA 9392783View commit details -
Configuration menu - View commit details
-
Copy full SHA for 57ed7ce - Browse repository at this point
Copy the full SHA 57ed7ceView commit details -
Configuration menu - View commit details
-
Copy full SHA for 235b832 - Browse repository at this point
Copy the full SHA 235b832View commit details
Commits on Feb 20, 2016
-
Configuration menu - View commit details
-
Copy full SHA for 623f945 - Browse repository at this point
Copy the full SHA 623f945View commit details -
Configuration menu - View commit details
-
Copy full SHA for f68488e - Browse repository at this point
Copy the full SHA f68488eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 9b60121 - Browse repository at this point
Copy the full SHA 9b60121View commit details
Commits on Feb 21, 2016
-
Add json testing && improve api mocking
Since we don't actually care about the implementation (“was `.json` called?”, “Was a `ValueError` catched?”, …), we don't need to mock the `Response` object and all of its functions. The better approach is to let the mocked `get`-function return an actual `Response` object, and setting the binary content (`content` is a property, thus `_content` is set). Now, the test only has to verify whether the binary represantation of a json-dump of a dict is being read into the same dict again.
Configuration menu - View commit details
-
Copy full SHA for fec450e - Browse repository at this point
Copy the full SHA fec450eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 7514aad - Browse repository at this point
Copy the full SHA 7514aadView commit details -
Explicitly test if 'post' was given for api call
It is more consequent to check explicitly for 'get' and 'post' as the `method`-argument for `do_api_call`. Also, add a test for the invalidity of something else.
Configuration menu - View commit details
-
Copy full SHA for 3b6626f - Browse repository at this point
Copy the full SHA 3b6626fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 273ba72 - Browse repository at this point
Copy the full SHA 273ba72View commit details -
Move model tests to own package
tests/model
Also, put the `gerok` and `sample` tests into their own module.
Configuration menu - View commit details
-
Copy full SHA for cee3c27 - Browse repository at this point
Copy the full SHA cee3c27View commit details -
Configuration menu - View commit details
-
Copy full SHA for 773615b - Browse repository at this point
Copy the full SHA 773615bView commit details -
Use
set
, notlist
for output comparisonUsing `list` would cause (under certain circumstances) the test to fail, just because the position of the returned elements in the list is different. Obviously, this is not what we want to test.
Configuration menu - View commit details
-
Copy full SHA for c474238 - Browse repository at this point
Copy the full SHA c474238View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8906546 - Browse repository at this point
Copy the full SHA 8906546View commit details -
Update the wrapper in
active_property
Forgetting this somehow bricked the abc-mechanism, which is not surprising, since not using `functools.wraps` for a decorator is foolish. SPOILER ALERT: I'm to blame.
Configuration menu - View commit details
-
Copy full SHA for 92c15f6 - Browse repository at this point
Copy the full SHA 92c15f6View commit details -
Delete unused
user_id
propertyWhat this ought to do was exactly the same as what `id` does. The difference is: one is being used, the other – not so much. This fixes the tests that got `broken` by actually fixing the `active_property` decorator in the previous commit. Lucky me.
Configuration menu - View commit details
-
Copy full SHA for 57fa9c4 - Browse repository at this point
Copy the full SHA 57fa9c4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5721e08 - Browse repository at this point
Copy the full SHA 5721e08View commit details
Commits on Feb 22, 2016
-
Add first test && structure for gerok.User tests
- Add the test structure, i.e. `TestGerokUser` class with example user, `User` comparison method and api mock - Add test testing an explicit creation via `__init__`
Configuration menu - View commit details
-
Copy full SHA for b612bd9 - Browse repository at this point
Copy the full SHA b612bd9View commit details -
Add test for
gerok.User.from_ip
, improve tests- Update the fake API to correctly parse the given query string (This was to add `find?ip={}` query functionality) - Test user creation via `User.from_ip` - Rename `id` to `user_id` where necessary (id is a builtin function)
Configuration menu - View commit details
-
Copy full SHA for 85f9345 - Browse repository at this point
Copy the full SHA 85f9345View commit details -
Fix
gerok.User.from_ip
and test for name- In `User.from_ip`, the constructor `cls()` has been called with a *completely different* signature, which last commit's test showed. - In the same run, cache the name on explicit user creation, and include `realname` in the tests.
Configuration menu - View commit details
-
Copy full SHA for eb89209 - Browse repository at this point
Copy the full SHA eb89209View commit details -
Allow generic
user_data
ingerok.User.__init__
It makes far more sense to pass the whole (and often used) `user_data` dict instead of the isolated parameters `name` and `mail`.
Configuration menu - View commit details
-
Copy full SHA for f1b50d7 - Browse repository at this point
Copy the full SHA f1b50d7View commit details -
Configuration menu - View commit details
-
Copy full SHA for a8423d6 - Browse repository at this point
Copy the full SHA a8423d6View commit details -
Configuration menu - View commit details
-
Copy full SHA for f536ea7 - Browse repository at this point
Copy the full SHA f536ea7View commit details
Commits on Feb 23, 2016
-
Allow empty redirection mail address
In the gerok module, the `mail` field of the API's `userdata` JSON-dict is supposed to be the redirection mail address. Thus, if it is empty, the `user.mail` property should contain the builtin mail address of the gerok module. The tests were extended so this usecase is in `assert_userdata_passed`.
Configuration menu - View commit details
-
Copy full SHA for 6692e1b - Browse repository at this point
Copy the full SHA 6692e1bView commit details -
Funnily, the inline `if` statement got parsed correctly.
Configuration menu - View commit details
-
Copy full SHA for 2c40b56 - Browse repository at this point
Copy the full SHA 2c40b56View commit details -
Configuration menu - View commit details
-
Copy full SHA for 26248a6 - Browse repository at this point
Copy the full SHA 26248a6View commit details -
Test
get
constructor && improve fake apiThe fake api got extended by the used `find?login=` functionality, a corresponding test for `user.get()` has been added.
Configuration menu - View commit details
-
Copy full SHA for 3fd9322 - Browse repository at this point
Copy the full SHA 3fd9322View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4a537b2 - Browse repository at this point
Copy the full SHA 4a537b2View commit details -
Add Test for
from_ip
with wrong ipsThis includes: - a fix in the `userData` comparisons asking whether nothing came back (`if not` is correct for the empty string, `do_api_call` never returns `None`) - a fix in the fake api concerning not being given an existent IP - a test with a few foreign IPs checking for `AnonymousUserMixin`.
Configuration menu - View commit details
-
Copy full SHA for 54ed4d9 - Browse repository at this point
Copy the full SHA 54ed4d9View commit details -
Add testing support for
credit
propertyThis is mostly implementation in the `fake_api`, the test itself is just an `AssertEqual`.
Configuration menu - View commit details
-
Copy full SHA for 5a155f4 - Browse repository at this point
Copy the full SHA 5a155f4View commit details -
Extensively test correct availability of traffic data in `gerok.User`.
Configuration menu - View commit details
-
Copy full SHA for a560636 - Browse repository at this point
Copy the full SHA a560636View commit details -
Intelligently create sample
user_data
The `user_data` being used in the `TestGerokUser` Case is now created as a mixture of the cartesian product of certain edgecases (combinations of missing traffic entries, 0-2 hosts) and an iterating, and thus unique, part contributing attributes like `name` and `password`.
Configuration menu - View commit details
-
Copy full SHA for d5e80fd - Browse repository at this point
Copy the full SHA d5e80fdView commit details -
Move assertions to specific tests
The assertions concerning the traffic entries belong in their own test.
Configuration menu - View commit details
-
Copy full SHA for 3218c53 - Browse repository at this point
Copy the full SHA 3218c53View commit details
There are no files selected for viewing
This file was deleted.
This file was deleted.