fix Log::Log4perl::FAQ not being indexed properly

metacpan · Feb 14, 2012 · 8b0aacd · 8b0aacd
1 parent d7fe7ed
commit 8b0aacd
Show file tree

Hide file tree

Showing 3 changed files with 22 additions and 4 deletions.
diff --git a/lib/MetaCPAN/Script/Release.pm b/lib/MetaCPAN/Script/Release.pm
@@ -343,12 +343,18 @@ sub import_tarball {
                 : 0
             ) unless ( $mod->indexed );
         }
-        $file->indexed( !!grep { $file->documentation eq $_->name }
-                @{ $file->module } )
-            if ( $file->documentation );
+        $file->indexed(
+
+            # .pm file with no package declaration but pod should be indexed
+            !@{ $file->module } ||
+
+           # don't index if the documentation doesn't match any of its modules
+                !!grep { $file->documentation eq $_->name } @{ $file->module }
+        ) if ( $file->documentation );
         log_trace {"reindexing file $file->{path}"};
         $file->clear_module if ( $file->is_pod_file );
         $bulk->put($file);
+
     }
     $bulk->commit;
 

diff --git a/t/release/moose.t b/t/release/moose.t
@@ -16,4 +16,12 @@ map { $first++ } grep { $_->first } @moose;
 
 ok($first, 'only one moose is first');
 
+ok(my $faq = $idx->type('file')->filter({
+    term => { 'file.documentation' => 'Moose::FAQ' }
+})->first, 'get Moose::FAQ');
+
+is($faq->status, 'latest', 'is latest');
+
+ok($faq->indexed, 'is indexed');
+
 done_testing;
diff --git a/t/var/fakecpan/configs/moose-recent.json b/t/var/fakecpan/configs/moose-recent.json
@@ -11,6 +11,10 @@
     {
         "file": "t/foo.t",
         "content": "use Test::More;"
-    } ]
+    },
+    {
+        "file": "lib/Moose/FAQ.pm",
+        "content": "1; \n\n=head1 NAME\n\nMoose::FAQ - abstract"
+    }]
   }
 }