Cleanup PC policy, fix mirrors to delete first #463

metacpan · Apr 26, 2016 · fd27271 · fd27271
1 parent 9af01ef
commit fd27271
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 3 deletions.
diff --git a/.perlcriticrc b/.perlcriticrc
@@ -11,7 +11,6 @@ verbose = 11
 [-RegularExpressions::RequireExtendedFormatting]
 [-RegularExpressions::RequireLineBoundaryMatching]
 [-Subroutines::ProhibitExplicitReturnUndef]
-[-ValuesAndExpressions::ProhibitAccessOfPrivateData]
 [-ValuesAndExpressions::ProhibitNoisyQuotes]
 [-Variables::ProhibitPunctuationVars]
 

diff --git a/lib/MetaCPAN/Script/Mirrors.pm b/lib/MetaCPAN/Script/Mirrors.pm
@@ -22,8 +22,13 @@ sub index_mirrors {
     my $ua   = LWP::UserAgent->new;
     log_info { 'Getting mirrors.json file from ' . $self->cpan };
 
-    my $json    = $self->cpan->file( 'indices', 'mirrors.json' )->slurp;
-    my $type    = $self->index->type('mirror');
+    my $json = $self->cpan->file( 'indices', 'mirrors.json' )->slurp;
+    my $type = $self->index->type('mirror');
+
+    # Clear out everything in the index
+    # so don't end up with old mirrors
+    $type->delete;
+
     my $mirrors = Cpanel::JSON::XS::decode_json($json);
     foreach my $mirror (@$mirrors) {
         $mirror->{location}