[packaging] ensure licensing info is included in artifacts #3839
+66
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* jars should have them in META-INF * bin tarball/zip should have them in top level
|
we shade some dependencies for jruby-core. jruby-stdlib does include complete jars from 3rd parties and then there are those aggregated artifacts: jruby-complete, jruby-jars (which is a gem), jruby-dist and maybe main jruby artifact. and finally there is lib/jruby.jar which is jruby-core with all its dependencies packed into one jar. |
|
travis looks good to me :) - thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now there's still a gap, namely aggregate NOTICE files for those artifacts that bundle 3rd party ASL licensed dependencies. I've done this before in other maven-based projects, but navigating JRuby's build is taking me a bit of time.