-
-
Notifications
You must be signed in to change notification settings - Fork 925
Permalink
Choose a base ref
{{ refName }}
default
Choose a head ref
{{ refName }}
default
Comparing changes
Choose two branches to see what’s changed or to start a new pull request.
If you need to, you can also or
learn more about diff comparisons.
Open a pull request
Create a new pull request by comparing changes across two branches. If you need to, you can also .
Learn more about diff comparisons here.
base repository: jruby/jruby
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 9563a0b4bd62
Could not load branches
Nothing to show
Loading
Could not load tags
Nothing to show
{{ refName }}
default
Loading
...
head repository: jruby/jruby
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 7a3c6379a1b8
Could not load branches
Nothing to show
Loading
Could not load tags
Nothing to show
{{ refName }}
default
Loading
- 3 commits
- 3 files changed
- 1 contributor
Commits on Apr 22, 2016
-
Configuration menu - View commit details
-
Copy full SHA for ba7cbb1 - Browse repository at this point
Copy the full SHA ba7cbb1View commit details -
Search all scopes in turn for refinements.
We were not properly handling the case of a method starting in a scope that is not a cref (class/module/script) body. The old logic would grab the current scope, find no refinements, and then move to the previous cref scope. This unfortunately would jump out of the current lexical cref into the containing lexical cref and miss any refinements in the current class body. We may be able to improve this by only searching cref scopes. Fixes #3548. See that bug for a reproduction.
Configuration menu - View commit details
-
Copy full SHA for 745654f - Browse repository at this point
Copy the full SHA 745654fView commit details -
Search for refinements for target class and all superclasses.
If you refine Integer, then calls against Fixnum should see that refinement. Obviously this is super inefficient right now and caches nothing. Relates to #3548.
Configuration menu - View commit details
-
Copy full SHA for 7a3c637 - Browse repository at this point
Copy the full SHA 7a3c637View commit details
There are no files selected for viewing