Fix FreeBSD linking issues #2560
Conversation
|
@myfreeweb I unfortunately know nothing about FreeBSD. @ysbaddaden if you think this is good you can merge it. You can freely choose what to do with stuff related to FreeBSD :-) |
| # where the default cc doesn't use /usr/local/lib by default | ||
| library_path.each do |path| | ||
| flags << " -L#{path}" | ||
| end |
There was a problem hiding this comment.
@asterite are you OK with this change?
There was a problem hiding this comment.
Hmmm... not sure. Could it only be done if the target platform is freebsd? I don't know if that could break something.
There was a problem hiding this comment.
Maybe? But I don't think adding -L/usr/lib -L/usr/local/lib can break anything anywhere… Do people not add this to all linker invocations?
|
@myfreeweb Could you rebase so that we get another Travis run? For some reason it didn't trigger. |
On FreeBSD, the default cc compiler does not have /usr/local/lib in its default library path. Usually pkg-config adds it.
|
Looks okay to me and easy to spot in case it breaks somewhere. Let's make it platform specific once we find a setup that it does break. Thank you! |
This PR:
LIBRARY_PATHto/lib:/usr/lib:/usr/local/libfrom @ysbaddaden's FreeBSD instructions.libmlinking on FreeBSD — examples likeneural_netnow work.redefine_mainthing is for OS X — on FreeBSD, it breaks everything, but the examples work without it).