Skip to content

Commit 7a6502a

Browse files
committedApr 21, 2016
CONTRIBUTING: disallow signed git commits
They break bzr-git, and bzr-git breaks the Minetest PPAs.
1 parent c350cfb commit 7a6502a

File tree

1 file changed

+1
-0
lines changed

1 file changed

+1
-0
lines changed
 

‎CONTRIBUTING.md

+1
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,7 @@ If you are planning to start some significant coding, you would benefit from ask
2525
- Have a title which begins with a capital letter
2626
- Be descriptive. (e.g. no `Update init.lua` or `Fix a problem`)
2727
- Have a first line with less than *80 characters* and have a second line that is *empty*
28+
- Do **not** [sign your commits](https://git-scm.com/book/uz/v2/Git-Tools-Signing-Your-Work), as Minetest offers automatically built ppas over launchpad and it [would break](https://bugs.launchpad.net/bzr-git/+bug/1084403) if there were signed commits in master
2829

2930
4. Once you are happy with your changes, submit a pull request.
3031
- Open the [pull-request form](https://github.com/minetest/minetest/pull/new/master)

1 commit comments

Comments
 (1)

nerzhul commented on Apr 23, 2017

@nerzhul
Contributor

reverted, thanks for the tip

Please sign in to comment.