-
-
Notifications
You must be signed in to change notification settings - Fork 925
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue deploying to tomcat with jruby-9.1.0.0. Cant find json-1.8.3-java #3850
Comments
this is annoying - its happening because its a default gem (from JRuby install) - thus does not get bundled. |
I am not really sure where the issue is coming from. |
I am getting the same error in a CI environment (Jenkins). |
any small reproduction case for me or more into. the info on this issue is too little to even try to reproduce it. |
@mkristian In my environment, the issue was triggered by a rogue "rake" command early in my path (/usr/local/bin). |
@mkristian The error was triggered on MRI 2.3.1 as well, but not on MRI 2.3.0. I deleted my rogue "rake" command to fix the problem, so I cannot tell which Ruby is was attached to. |
@donv thanks for looking into it. |
@MrToastyToast Can you show a log of doing a clean build and deploy of your app using https://gist.github.com please? @kares What makes you say that? The same json version was a default gem in 9.0.5.0 too. I would be more likely to suspect RubyGems, but it's Bundler raising the error. |
@headius do have json 1.8.1 in 9.0.5.0 installed using RVM ... did Warbler experiments and it seemed to me that packing default gems never really worked. downgrading to 1.8.2 in the bundle should confirm this. |
@kares Ahh, I stand corrected. Why does 1.8.3 cause this? |
package an app using warbler with json locked to 1.8.3 (under 9.1.0.0) ... the .war/.jar will fail to boot. now that I think of it needs a check whether its an issue with Bundler failing to find a default gem from jruby-jars. |
so this fails with bundler: https://gist.github.com/mkristian/5738370aba7d6cbe38d516cfdc07d992 but without the problem is the same as I monkey patched with jruby-mains: it is to blame me as I know this problem more then year and I never found the time to prepare a PR for bundler. instead improving this monkey patch a few times already. BUT I am not sure if this is the complete story as it gives a totally different error ! |
@mkristian Will you put together a patch for Bundler and link us? Is there any workaround for now other than downgrading rake? We need an answer for 9.1.1.0. |
@headius for the simple jar I created with warbler in that gist of mine, there is no work around beside warbler adding this monkey patch in its META-INF/init.rb . and this should not be something new or maybe new with warbler-2.0.0, not sure why it never was reported on warbler, but with packing jar with maven and gradle this was the first thing we saw. will look into a simple war file later today, as the rubygems/bundler#4565 is jar specific problem. |
we should fix this on warbler. it is not the really the fault of bundler, that |
@mkristian agreed, that Warbler should do smt about this .. will look later unless its fixed by than 💤 |
So what's the status here? Do we have anything to fix in JRuby or is this all external? |
nope - nothing to be done here ... its not really a regression at JRuby's |
Environment
jruby 9.1.0.0 (2.3.0) 2016-05-02 a633c63 Java HotSpot(TM) 64-Bit Server VM 25.91-b14 on 1.8.0_91-b14 +jit [linux-x86_64]
Ubuntu 14.04.04
java version "1.7.0_95"
OpenJDK Runtime Environment (IcedTea 2.6.4) (7u95-2.6.4-0ubuntu0.14.04.2)
OpenJDK 64-Bit Server VM (build 24.95-b01, mixed mode)
Expected Behavior
Create a war file that runs on tomcat6
Actual Behavior
After updating to jruby-9.1.0.0 we got this exception on boot
Specifically adding json-1.8.3 with platform
:jruby
into gemfile did not work as wellThe text was updated successfully, but these errors were encountered: