Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

t/27inline_maker.t test fails with ExtUtils-MakeMaker-7.12 #51

Closed
ppisar opened this issue Apr 20, 2016 · 6 comments
Closed

t/27inline_maker.t test fails with ExtUtils-MakeMaker-7.12 #51

ppisar opened this issue Apr 20, 2016 · 6 comments

Comments

@ppisar
Copy link
Contributor

ppisar commented Apr 20, 2016

After upgrading ExtUtils-MakeMaker from 7.10 to 7.12 t/27inline_maker.t test fails:

t/26fork.t ............... ok
#   Failed test 'make test'
#   at t/27inline_maker.t line 60.
# make[1]: Entering directory '/builddir/build/BUILD/Inline-C-0.76/_Inline_27inline_maker.16203/src dir'
# cp lib/Boo/Far/Faz.pm blib/lib/Boo/Far/Faz.pm
# cp lib/Boo/Far.pm blib/lib/Boo/Far.pm
# cp lib/Boo.pm blib/lib/Boo.pm
# cp lib/Boo/Far/data.txt blib/lib/Boo/Far/data.txt
# "/usr/bin/perl" -Mblib -MInline=NOISY,_INSTALL_ -MBoo -e"my %A = (modinlname => 'Boo.inl', module => 'Boo'); my %S = (API => \%A); Inline::satisfy_makefile_dep(\%S);" 2.01 blib/arch
# Can't locate Boo.pm in @INC (you may need to install the Boo module) (@INC contains: /builddir/build/BUILD/Inline-C-0.76/_Inline_27inline_maker.16203/src dir/../../blib/arch /builddir/build/BUILD/Inline-C-0.76/_Inline_27inline_maker.16203/src dir/../../blib/lib /builddir/build/BUILD/Inline-C-0.76/blib/lib /builddir/build/BUILD/Inline-C-0.76/blib/arch /usr/local/lib/perl5 /usr/local/share/perl5 /usr/lib/perl5/vendor_perl /usr/share/perl5/vendor_perl /usr/lib/perl5 /usr/share/perl5 .).
# BEGIN failed--compilation aborted.
# Makefile:843: recipe for target 'Boo.inl' failed
# make[1]: Leaving directory '/builddir/build/BUILD/Inline-C-0.76/_Inline_27inline_maker.16203/src dir'
# make[1]: *** [Boo.inl] Error 2
#   Failed test 'make test'
#   at t/27inline_maker.t line 60.
# make[1]: Entering directory '/builddir/build/BUILD/Inline-C-0.76/_Inline_27inline_maker.16203/src dir'
# cp Simple.pm blib/lib/Math/Simple.pm
# "/usr/bin/perl" -Mblib -MInline=NOISY,_INSTALL_ -MMath::Simple -e"my %A = (modinlname => 'Math-Simple.inl', module => 'Math::Simple'); my %S = (API => \%A); Inline::satisfy_makefile_dep(\%S);" 1.23 blib/arch
# Can't locate Math/Simple.pm in @INC (you may need to install the Math::Simple module) (@INC contains: /builddir/build/BUILD/Inline-C-0.76/_Inline_27inline_maker.16203/src dir/../../blib/arch /builddir/build/BUILD/Inline-C-0.76/_Inline_27inline_maker.16203/src dir/../../blib/lib /builddir/build/BUILD/Inline-C-0.76/blib/lib /builddir/build/BUILD/Inline-C-0.76/blib/arch /usr/local/lib/perl5 /usr/local/share/perl5 /usr/lib/perl5/vendor_perl /usr/share/perl5/vendor_perl /usr/lib/perl5 /usr/share/perl5 .).
# BEGIN failed--compilation aborted.
# Makefile:837: recipe for target 'Math-Simple.inl' failed
# make[1]: *** [Math-Simple.inl] Error 2
# make[1]: Leaving directory '/builddir/build/BUILD/Inline-C-0.76/_Inline_27inline_maker.16203/src dir'
# Looks like you failed 2 tests of 8.
t/27inline_maker.t ....... 
Dubious, test returned 2 (wstat 512, 0x200)
Failed 2/8 subtests 

According to CPAN test matrix, it fails even with ExtUtils-MakeMaker-7.11_01.

@ppisar
Copy link
Contributor Author

ppisar commented Apr 22, 2016

This looks similar to #49 caused by ExtUtils-MakeMaker-7.06 and fixed by revert in ExtUtils-MakeMaker-7.08.

@sisyphus
Copy link
Collaborator

From: Petr Pisar
Sent: Friday, April 22, 2016 9:02 PM
To: ingydotnet/inline-c-pm
Subject: Re: [ingydotnet/inline-c-pm] t/27inline_maker.t test fails with
ExtUtils-MakeMaker-7.12 (#51)

This looks similar to #49 caused by ExtUtils-MakeMaker-7.06 and fixed by
revert in ExtUtils-MakeMaker-7.08.

I think it also looks similar to
#50 .

We know that all is good in EU-MM-7.10_01 (which ships with 5.24-.0-RC1) and
according to the EU::MM maintainer (see
http://www.nntp.perl.org/group/perl.perl5.porters/2016/04/msg235954.html)
all of the fixes in 7.10_01 have been put into 7.12.
But that would imply that that 7.12 has come up with a completely new way of
breaking these very same Inline::C tests - which seems unlikely.

Has the code that was reverted in 7.08 been re-reverted back to the "7.06"
state in 7.12 ?

Cheers,
Rob

@Leont
Copy link

Leont commented Apr 22, 2016

This looks similar to #49 caused by ExtUtils-MakeMaker-7.06 and fixed by revert in ExtUtils-MakeMaker-7.08.

It pretty much has to be, the changes in 7.06 were reverted in 7.08 until we fixed all known issues, but somehow this one didn't seem to have percolated to the toolchain gang on time (otherwise it would have been dealt with earlier.

@sisyphus
Copy link
Collaborator

Tests passing again on Ubuntu for me with ExtUtils-MakeMaker-7.14.

@Leont
Copy link

Leont commented Apr 24, 2016

Tests passing again on Ubuntu for me with ExtUtils-MakeMaker-7.14.

You're welcome :-)

@ppisar
Copy link
Contributor Author

ppisar commented Apr 25, 2016

Indeed, it works with 7.14 (the only change was make dynamic target to depend on config target). Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants