Implement --delete-generations + flag for keeping last N number of gens #767

mogorman · 2016-01-07T01:18:24Z

I don't find keeping last X days of generations as useful to me as keeping the last X number of generations. so I implemented it.

domenkozar · 2016-03-28T09:11:27Z

cc @edolstra

edolstra · 2016-04-14T19:35:30Z

src/libstore/profiles.hh

@@ -37,6 +37,8 @@ void deleteGeneration(const Path & profile, unsigned int gen);

 void deleteGenerations(const Path & profile, const std::set<unsigned int> & gensToDelete, bool dryRun);

+void deleteGenerationsGreaterThan(const Path & profile, const string & max, bool dryRun);


max should be an integer. (I.e. the conversion to int should be done in nix-env.cc where the argument parsing happens.)

edolstra · 2016-04-14T19:36:21Z

Looks good apart from my two comments.

mogorman · 2016-05-19T19:43:33Z

fixes what was brought up in comments

Profpatsch · 2017-03-30T21:37:38Z

merge?

mogorman · 2017-09-20T18:49:41Z

bump from mailinglist

mogorman · 2017-09-21T20:04:54Z

@edolstra or @domenkozar could you take a look if you get the time?

jb55

Looking forward to this! Just noticed a possible typo.

jb55 · 2017-09-21T21:03:05Z

src/nix-env/nix-env.cc

+    } else if (opArgs.size() == 1 && opArgs.front().find('+') != string::npos) {
+        if(opArgs.front().size() < 2)
+            throw Error(format("invalid number of generations ‘%1%’") % opArgs.front());
+        string str_max = string(opArgs.front() 1, opArgs.front().size());


typo here? opArgs.front() 1

mogorman · 2017-09-22T01:41:48Z

yup you were right i hadnt rerun it when i made that change

edolstra · 2017-12-19T18:02:45Z

src/libstore/profiles.hh

@@ -37,6 +37,8 @@ void deleteGeneration(const Path & profile, unsigned int gen);

 void deleteGenerations(const Path & profile, const std::set<unsigned int> & gensToDelete, bool dryRun);

+void deleteGenerationsGreaterThan(const Path & profile, const int max, bool dryRun);


Can deleteGenerations be removed? It looks like a special case of deleteGenerationsGreaterThan with max=1.

No, deleteGenerations can be given a list of specific generations where as mine will only keep x in chronological order, or the date one will only keep so many dates back.

@edolstra any chance we can get this merged before 18.03 release?

I suppose we could unify the two functions by simply having deleteGenerationsOlderThan build the std::set and then pass it into deleteGenerations. I doubt the deduplication would be that valuable though.

Although I did notice that you don't check against curGen, but deleteGenerations does. Do you do anything to ensure you don't delete the current generation? If not, perhaps it'd pay to just call the existing function with the set you computed.

@copumpkin I could be mistaken but rereading the logic I wrote, it shouldn't be possible to delete the current generation, the list of gens checks to see if it hits the end of generations and bails out at that point.

@copumpkin you were correct that it would have been possible to have deleted the currentgeneration if you had done enough rollbacks. I have modified the code to make sure this is not possible

dtzWill · 2018-03-01T22:17:52Z

Is the last generation always the current one, even after rollback and such?

mogorman · 2018-03-02T02:47:13Z

I am going to confirm the delete current generation issue now in a roll back situation now.

…nerations

missing comma

generation is not the one we are deleting

well

mogorman · 2018-03-02T04:01:59Z

thanks @dtzWill i went back and changed the logic slightly. now it starts the count from the current generation rather than the beginning of the list. I also updated docs to explain this. I think this is more likely what people will want. I would say this is good to go again.

jackjennings · 2018-05-31T07:41:36Z

Any chance this is still on the table? This would help put immensely in a nixops managed server that consistently runs out of space unless cleaned up manually. Being able to only keep the last N generations would make keeping the disk relatively empty much easier.

I would be happy to contribute if some manual tasks need to be performed to update this pull request to work with the latest release…

peti · 2018-05-31T07:56:45Z

This will do it:

$ cd /nix/var/nix/profiles
$ ls -1d system-*-link | head -n -5 | xargs --no-run-if-empty rm
# nix-collect-garbage

mogorman · 2018-05-31T08:06:34Z

woohoo

jackjennings · 2018-05-31T12:35:49Z

Thank you @peti!

mogorman mentioned this pull request Feb 6, 2016

Support "nix-collect-garbage -d --keep-generations 2" #175

Closed

edolstra reviewed Apr 14, 2016
View reviewed changes

domenkozar added the feature Feature request or proposal label Jul 21, 2016

jb55 suggested changes Sep 21, 2017

View reviewed changes

edolstra reviewed Dec 19, 2017

View reviewed changes

mogorman mentioned this pull request Feb 1, 2018

Feature freeze for nix 1.12? #1806

Closed

mogorman and others added 3 commits March 1, 2018 21:47

Implement --delete-generations + flag for keeping last N number of ge…

429154b

…nerations

this updates issues that were addressed by people in pr

0312d30

Update nix-env.cc

12fe224

missing comma

mogorman force-pushed the garbage_collect_keep_last_few branch from 9057aa1 to 12fe224 Compare March 2, 2018 02:48

mogorman added 2 commits March 1, 2018 22:22

remove unused variable and make sure to check that the current

3c16044

generation is not the one we are deleting

only delete things older than current gen and update logic in doc as

467fdd8

well

shlevy added the backlog label Apr 1, 2018

shlevy assigned peti Apr 1, 2018

peti merged commit 93aa3be into NixOS:master May 31, 2018

mogorman deleted the garbage_collect_keep_last_few branch May 31, 2018 08:06

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Implement --delete-generations + flag for keeping last N number of gens #767

Implement --delete-generations + flag for keeping last N number of gens #767

mogorman commented Jan 7, 2016

domenkozar commented Mar 28, 2016

edolstra Apr 14, 2016

edolstra commented Apr 14, 2016

mogorman commented May 19, 2016

Profpatsch commented Mar 30, 2017

mogorman commented Sep 20, 2017

mogorman commented Sep 21, 2017

jb55 left a comment

jb55 Sep 21, 2017

mogorman commented Sep 22, 2017

edolstra Dec 19, 2017

mogorman Jan 18, 2018

mogorman Jan 21, 2018

copumpkin Mar 1, 2018

mogorman Mar 1, 2018

mogorman Mar 2, 2018

dtzWill commented Mar 1, 2018

mogorman commented Mar 2, 2018

mogorman commented Mar 2, 2018

jackjennings commented May 31, 2018

peti commented May 31, 2018 •

edited

mogorman commented May 31, 2018

jackjennings commented May 31, 2018

		@@ -37,6 +37,8 @@ void deleteGeneration(const Path & profile, unsigned int gen);

		void deleteGenerations(const Path & profile, const std::set<unsigned int> & gensToDelete, bool dryRun);

		void deleteGenerationsGreaterThan(const Path & profile, const string & max, bool dryRun);

Implement --delete-generations + flag for keeping last N number of gens #767

Implement --delete-generations + flag for keeping last N number of gens #767

Conversation

mogorman commented Jan 7, 2016

domenkozar commented Mar 28, 2016

Choose a reason for hiding this comment

edolstra commented Apr 14, 2016

mogorman commented May 19, 2016

Profpatsch commented Mar 30, 2017

mogorman commented Sep 20, 2017

mogorman commented Sep 21, 2017

jb55 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mogorman commented Sep 22, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dtzWill commented Mar 1, 2018

mogorman commented Mar 2, 2018

mogorman commented Mar 2, 2018

jackjennings commented May 31, 2018

peti commented May 31, 2018 • edited

mogorman commented May 31, 2018

jackjennings commented May 31, 2018

peti commented May 31, 2018 •

edited