Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tag template (base and base-jinja) #2212

Closed
wants to merge 1 commit into from
Closed

Fix tag template (base and base-jinja) #2212

wants to merge 1 commit into from

Conversation

angelgcuartero
Copy link

Somehow this got broken in the past and now it doesn’t have the right
field order. It has to be first the post title and second, the date.

Somehow this got broken in the past and now it doesn’t have the right
field order. It has to be first the post title and second, the date.
@da2x
Copy link
Contributor

da2x commented Jan 7, 2016

Look in the git history. Someone changed this on purpose. You can change the presentation order using CSS position (position: relative; on parent, then position: absolute; left: 0; and position: absolute; right: 0; in the order you want).

Also, Python’s isoformat() and Nikola’s 'webiso' doesn’t produce the same date format. 'webiso' is a subset of ISO8601 for the web and this subset is required for a valid HTML5 datetime. This subset is used by Atom, Sitemaps, and other web standard formats.

@angelgcuartero
Copy link
Author

Sorry if I made a mistake pushing changes to the repo… I was trying to do some branching and commit locally and Github Desktop seemed like it was not refreshing info correctly. I might have send a PR when I was doing tests (not a git expert).

Anyway, I was testing a standard installation and it doesn't show the tag post list right. Either the template is not right or the code to inject the data into the template is not doing it as it should be, I think. I will look for more information.

@Kwpolska
Copy link
Member

Kwpolska commented Jan 7, 2016

@Aeyoun This change would be fine, if it was implemented properly. As of right now, the default themes look like this:

Which is just plain awful. I’ll fix this by updating the CSS and other files that use .listdate and .listtitle… In the future, please check how things look in the built-in themes.

Kwpolska added a commit that referenced this pull request Jan 7, 2016
Signed-off-by: Chris Warrick <kwpolska@gmail.com>
@Kwpolska
Copy link
Member

Kwpolska commented Jan 7, 2016

Superseded by #2213. Thanks for reporting the bug!

@Kwpolska Kwpolska closed this Jan 7, 2016
@Kwpolska Kwpolska added this to the v7.7.5 milestone Jan 7, 2016
@Kwpolska Kwpolska self-assigned this Jan 7, 2016
ralsina added a commit that referenced this pull request Jan 8, 2016
Fix #2212 -- display dates in lists properly
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants