(triage) As far as I can tell, it's still relevant.

@peti would you like to review this?

I'm not sure what to do with this patch. It does a problem we have (albeit not an urgent one), so we want to merge, I suppose. On the other hand, the patch duplicates code that we probably don't want to duplicate. Instead, the proper implementation of callPackageWith should be refactord/extended. Doing that is a bit of an effort, though, and I don't see anyone who's willing to dedicate that effort right now. So it seems like we're stuck.

I don't think that the duplicated code should be of much concern: it is only 3 lines that are duplicated (the drv and auto let bindings + the code for the in). Anyway, I rebased the branch to be compatible with master.

@bennofs can you verify that master still needs this fix?

@domenkozar yes still necessary:

d-cube:/c/nixpkgs (master=) nix-build -E 'with (import ./. {}); (haskellPackages.acme-realworld.override {}).overrideScope (self: super: {})'
error: attribute ‘overrideScope’ missing, at (string):1:23

@bennofs, your example was not fixed by #22613?

@peti yes still:

 $ git pull; nix-build -E 'with (import ./. {}); (haskellPackages.acme-realworld.override {}).overrideScope (self: super: {})'
Already up-to-date.
error: attribute ‘overrideScope’ missing, at (string):1:23

How should that patch fix this? The issue is that overrideScope ìs not added "under" callPackage, but instead is added directly to the result of callPackage. So callPackage doesn't know about the extra attribute, and the override function will no re-add it after re-calling the package with new arguments,

@peti so any idea how we progress with this? it's currently one of the oldest PRs on the nixpkgs repo, and I don't think that more time will change the situation. So it seems we have three options:

1. leave the code as is. I'm not sure how common it is to want to call overrideScope after override, but it is probably bad if you want to overrideScope a pkg that has overrides defined by some of the standard -configuration overrides.
2. copy 3 lines from customization.nix and adapt them
3. change customization.nix to support this, which might break other parts of nixpkgs in unforseen ways (will need lots of reviews for sure)

@bennofs, I think option (2) is the best solution. The code duplication is unfortunate, but I don't see any reasonable way around it. Would you mind pushing an updated version of this patch that fixes the merge conflicts? I'll be happy to merge the PR then.

Merged to haskell-updates for test-building in b39964cec5d505c00196ff0983b9fe008aac8401.

@peti I rebased to master and force-pushed.

edit: oh I see you already noticed! 👍

Something isn't right: http://hydra.nixos.org/jobset/nixpkgs/haskell-updates. After b39964cec5d505c00196ff0983b9fe008aac8401 was added to the branch, stack is broken, apparently because the override

  stack = super.stack.overrideScope (self: super: {
    store-core = self.store-core_0_3;
    store = self.store_0_3_1;
  });

no longer works as before.

@peti that is... weird. I will investigate.

@peti fixed. stack compiles now. I added some docs that explain the the trickiness here.