oraclejdk8jce oraclejre8jce: add JCE versions JDK8 & JRE8 #9361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The build failure is not related to this patch: I will investigate if there are any pending fixes for this already. |
mbbx6spp
force-pushed
the
fix-oraclejdk8-installjce
branch
from
0f590e3
to
83146aa
Compare
Currently not JCE installed version of Oracle JDK8 or JRE8 are provided. This
change addresses that by added new packages named:
* `oraclejdk8jce`: this is the JCE installed version of oraclejdk8
* `oraclejre8jce`: this is the JCE installed version of oraclejre8
This also fixes the `installjce` logic where in JDK/JRE8 the name of the
unlimited JCE policy directory added a suffix of JDK8 by adding wildcard.
I tested this off of commit `1357692` with this patch applied checking the
JARs in `jre/lib/security` subdir are different in the non-JCE version with
the JCE installed version like so:
```bash
nix-env -f . -iA oraclejdk8
declare jhome=$(dirname $(readlink -f $(which java)))/..
shasum ${jhome}/jre/lib/security/*.jar
nix-env -f . -iA oraclejdk8jce
declare jhome=$(dirname $(readlink -f $(which java)))/..
shasum ${jhome}/jre/lib/security/*.jar
```
mbbx6spp
force-pushed
the
fix-oraclejdk8-installjce
branch
from
83146aa
to
120565c
Compare
|
(triage) Doesn't seem to be fixed yet. |
|
Closing due to no reply on the triage, feel free to reopen / ask for it to be reopened :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently not JCE installed version of Oracle JDK8 or JRE8 are provided. This change addresses that by added new packages named:
oraclejdk8jce: this is the JCE installed version of oraclejdk8oraclejre8jce: this is the JCE installed version of oraclejre8This also fixes the
installjcelogic where in JDK/JRE8 the name of the unlimited JCE policy directory added a suffix of JDK8 by adding wildcard.I tested this off of commit
1357692with this patch applied checking the JARs injre/lib/securitysubdir are different in the non-JCE version with the JCE installed version like so:Cheers.