Skip to content

Commit

Permalink
flash: close tempfile before deleting (#256)
Browse files Browse the repository at this point in the history
@sbourdeauducq
sbourdeauducq committed May 20, 2016
1 parent 5f7f4ed commit 5f11dbf
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions artiq/frontend/artiq_flash.py
View file
Original file line number Diff line number Diff line change
@@ -129,6 +129,7 @@ def main():
])
finally:
if conv:
os.close(bin_handle)
os.unlink(bin)


6 comments on commit 5f11dbf

@jordens
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is already done in bit2bin()

@sbourdeauducq
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So why does @kellyjoe39 seem to need another close?

@jordens
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code she is referencing does not exist.

@kemstevens
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm still working off qc1 from anaconda and was typing in patches using vi so perhaps that caused some confusion. Do I need to move to the latest release? Or a source code installation? I don't savor the idea of trying to build all of your code on windows...

@sbourdeauducq
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay so you will need all those three patches in sequence:
3ae44e7
18878ba
109ddf9

They are in our anaconda dev channel (with nist_clock, which is the main platform we build/test on) but not in the main channel yet.

@jordens
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we built those packages (from release-1). But we can do that. I'll let you know when they are available.

Please sign in to comment.