Skip to content

Commit

Permalink
Showing 2 changed files with 17 additions and 1 deletion.
16 changes: 16 additions & 0 deletions test/test_helper.rb
Original file line number Diff line number Diff line change
@@ -106,3 +106,19 @@ def assert_in_sub_runtime(script)
assert run_in_sub_runtime(script)
end
end

require 'test/unit'

class Test::Unit::TestCase

unless method_defined?(:skip)
if method_defined?(:omit)
alias skip omit
else
def skip(msg = nil)
warn "Skipped: #{caller[0]} #{msg}"
end
end
end

end
2 changes: 1 addition & 1 deletion test/test_java_extension.rb
Original file line number Diff line number Diff line change
@@ -294,7 +294,7 @@ def protected_method; "HELLO!" end
end

def test_calling_abstract_method_in_java_constructor
skip('this leaking in super constructor (calling Ruby implemented methods)')
return skip('this leaking in super constructor (calling Ruby implemented methods)')
a = CallAbstractInConstructor.new
assert_equal "HELLO!", a.result
end

3 comments on commit f5c974a

@headius
Copy link
Member

@headius headius commented on f5c974a May 9, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we just remove this? The "return" change is producing this warning for the subsequent line:

jruby/test/jruby/test_java_extension.rb:314: warning: statement not reached

@headius
Copy link
Member

@headius headius commented on f5c974a May 9, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ping @kares to get through the noise...

Sorry, something went wrong.

@kares
Copy link
Member Author

@kares kares commented on f5c974a May 10, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be fine to remove on master ... it was mostly due jruby-1_7

Sorry, something went wrong.

Please sign in to comment.