Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

File.expand_path does not have unique representation #3881

Open
mkristian opened this issue May 12, 2016 · 4 comments
Open

File.expand_path does not have unique representation #3881

mkristian opened this issue May 12, 2016 · 4 comments

Comments

@mkristian
Copy link
Member

those issues dealing with normalizing the path representation of a file when they need to compare them:
rubygems/bundler#4565
88e9f75

here are some collection of issues to improve normalization of paths, File.expand_path is the main but not only target.
#3771
#3487
#2021

@mkristian
Copy link
Member Author

in rubygems/bundler#4565 the main issue is that
uri:classloader:/path/to/a not equals to uri:classloader://path/to/a and both came out of the File.expand_path (as far I understand things)

@headius
Copy link
Member

headius commented May 18, 2016

Did this break recently?

@headius
Copy link
Member

headius commented May 18, 2016

Also, does this make rubygems/bundler#4565 and rubygems/bundler#4566 irrelevant? cc @lynnco

@mkristian
Copy link
Member Author

is does fix problems like rubygems/bundler#4565 and rubygems/bundler#4566 where code assume it can compare paths from File.expand_path - but it is nothing new.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants