Rescue doesn't accept global type path #2593
Merged
+6
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mosop Thank you! The code is perfect except for one bit: don't use %i(...), as it creates a new array each time code reaches that point. Better switch on the token's type. Maybe there's another overload for check that accepts many symbols.Or otherwise move the array to a constant (this is done in some places in the parser), but I think a simple if/elsif or case/when is enough here. |
mosop
force-pushed
the
rescue_accepts_global_type_path
branch
from
4532688 to
2267a28
Compare
|
@asterite Hi. I changed the local array into a constant. I understand your preferred way, a simple if/elsif or case/when, but I think it may need a little more complex implementation and maybe additional test specs for message formatting. Thank you. |
|
@mosop Don't worry, the fix is already perfect, I'll take care of the formatter. Thank you! ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This code occurs a compiler's error because the parser doesn't accept global type paths at rescue:
I quickly fixed the corresponding source code, but it may be not perfect. In addition, my code doesn't consider Underscore nodes like:
Thank you.