Compiler: preserve attributes generated by macro code

crystal-lang · Jun 2, 2016 · 36ab7e8 · 36ab7e8
1 parent 38b04f5
commit 36ab7e8
Showing 2 changed files with 19 additions and 0 deletions.
diff --git a/spec/compiler/type_inference/lib_spec.cr b/spec/compiler/type_inference/lib_spec.cr
@@ -517,6 +517,23 @@ describe "Type inference: lib" do
     attrs[0].lib.should eq("SDL")
   end
 
+  it "gathers link attributes from macro expression" do
+    result = infer_type(%(
+      {% begin %}
+        @[Link("SDL")]
+      {% end %}
+      lib LibSDL
+        fun init = SDL_Init : Int32
+      end
+
+      LibSDL.init
+      ))
+    sdl = result.program.types["LibSDL"].as(LibType)
+    attrs = sdl.link_attributes.not_nil!
+    attrs.size.should eq(1)
+    attrs[0].lib.should eq("SDL")
+  end
+
   it "errors if using void as argument (related to #508)" do
     assert_error %(
       lib LibFoo

diff --git a/src/compiler/crystal/semantic/base_type_visitor.cr b/src/compiler/crystal/semantic/base_type_visitor.cr
@@ -332,6 +332,8 @@ module Crystal
           unless node.expanded
             @attributes = nil
           end
+        when MacroExpression, MacroIf, MacroFor
+          # Don't clear attributes that were generating with macros
         else
           @attributes = nil
         end