Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide an empty implementation of find_classes_with_matching_source_line #3875

Closed
wants to merge 1 commit into from
Closed

Conversation

jtulach
Copy link
Contributor

@jtulach jtulach commented May 11, 2016

Without it I have problems using unit testing in other mx suites:

    mx_unittest.unittest(['-cmd', '-polyglot', 'com.oracle.truffle.pe.test'])
  File "mx/mx_unittest.py", line 317, in unittest
    _unittest(args, ['@Test', '@Parameters'], **parsed_args.__dict__)
  File "mx/mx_unittest.py", line 217, in _unittest
    _run_tests(args, harness, vmLauncher, annotations, testfile, blacklist, whitelist, regex, mx.suite(suite) if suite else None)
  File "mx/mx_unittest.py", line 91, in _run_tests
    for c in _find_classes_with_annotations(p, None, annotations):
  File "mx/mx_unittest.py", line 45, in _find_classes_with_annotations
    return p.find_classes_with_matching_source_line(pkgRoot, matches, includeInnerClasses)
AttributeError: 'MavenProject' object has no attribute 'find_classes_with_matching_source_line'

@eregon
Copy link
Member

eregon commented May 11, 2016

Could you reapply this change on top of master in a new PR? It makes it easier for us to keep the branches in sync and avoid too large diffs.

@eregon eregon closed this May 11, 2016
@eregon eregon added this to the truffle-dev milestone May 11, 2016
@eregon eregon added the truffle label May 11, 2016
@enebo enebo added this to the Non-Release milestone Dec 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants