Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update documentation to reflect compiler command change #2726

Merged
merged 2 commits into from
Jun 14, 2016

Conversation

keplersj
Copy link
Contributor

@keplersj keplersj commented Jun 2, 2016

Reflects changes made in #2725

keplersj added 2 commits June 2, 2016 13:48

Verified

This commit was signed with the committer’s verified signature.
jhass Jonne Haß
Also update the command examples.
@jhass
Copy link
Member

jhass commented Jun 2, 2016

Looks good, would you dare to squash the commits together?

@bcardiff
Copy link
Member

bcardiff commented Jun 2, 2016

This should not me merged prior the release of #2725 :-)
Otherwise it will get published right away.

@keplersj
Copy link
Contributor Author

keplersj commented Jun 2, 2016

@jhass I thought GitHub allowed squashing on Pull Request merge?

@jhass
Copy link
Member

jhass commented Jun 2, 2016

It does, but it's apparently not enabled for this repo and I still like a merge commit referencing the PR ;)

@keplersj
Copy link
Contributor Author

keplersj commented Jun 2, 2016

Okay, I'll squash!

@ysbaddaden
Copy link
Contributor

@jhass I do have the option to squash when merging on this repo, and already used it when merging simple PR (like typos).

@jhass
Copy link
Member

jhass commented Jun 2, 2016

Oh, it's behind the button, mmh

@keplersj
Copy link
Contributor Author

keplersj commented Jun 2, 2016

Should I still squash these commits?

@asterite
Copy link
Member

asterite commented Jun 2, 2016

I started to use the squash button as soon as github added it, I think it's great :-)

(though it took me a while to find it)

@fernandes
Copy link
Contributor

@jhass it keeps the PR reference inside the parenthesis 👍

@jhass jhass merged commit b56599b into crystal-lang:gh-pages Jun 14, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants