Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'compile' command as an alias of the 'build' command. #2725

Merged
merged 1 commit into from
Jun 2, 2016

Conversation

keplersj
Copy link
Contributor

@keplersj keplersj commented Jun 2, 2016

Fixes #502

@@ -8,6 +8,7 @@ class Crystal::Command
Command:
init generate a new project
build compile program
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually perhaps we should even already remove it here.

@keplersj keplersj changed the title [WIP] Add 'compile' command as an alias of the 'build' command. Add 'compile' command as an alias of the 'build' command. Jun 2, 2016
options.shift
build
compile command
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the usage saying "compile" when "build" is still used would actually be a good thing :)

@jhass
Copy link
Member

jhass commented Jun 2, 2016

Great, now some squashing would be great here too ;)

Remove 'build' command from compiler usage.

Unify build/compile handling.

Update compiler spec to use new 'compile' command.

Compile/build command's name now always 'compile'.
@keplersj
Copy link
Contributor Author

keplersj commented Jun 2, 2016

Squashed!

@ysbaddaden
Copy link
Contributor

I thought we didn't like aliases?

@jhass
Copy link
Member

jhass commented Jun 2, 2016

We don't, but then this is so essential that we need to phase it out IMO. So the current plan is to add this as an alias, update all references we can update to compile and then at some later release remove build.

@jhass
Copy link
Member

jhass commented Jun 2, 2016

Also our own Makefile would break otherwise.

@ysbaddaden
Copy link
Contributor

Thanks! There was no indication about a deprecation of the build command.

@asterite
Copy link
Member

asterite commented Jun 2, 2016

Oh, a deprecation warning is very good indeed, so users can learn about the new command.

@keplersj
Copy link
Contributor Author

keplersj commented Jun 2, 2016

Travis is green!

@jhass jhass merged commit 97e8db9 into crystal-lang:master Jun 2, 2016
jhass added a commit that referenced this pull request Jun 2, 2016
Add 'compile' command as an alias of the 'build' command.
@jhass
Copy link
Member

jhass commented Jun 2, 2016

Thank you!

@keplersj keplersj deleted the compile-command branch June 2, 2016 21:02
@keplersj
Copy link
Contributor Author

keplersj commented Jun 2, 2016

Woot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants