Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compiler: allow using macros inside lib declarations. Part of #2710 #2724

Merged
merged 1 commit into from
Jun 2, 2016

Conversation

asterite
Copy link
Member

@asterite asterite commented Jun 2, 2016

This implements the second part of #2710. With this, macros can be used in places where one can use ifdef: inside a lib, and inside a struct/union definition. This covers all current cases, so next we'll be able to remove ifdef from the language.

@jhass
Copy link
Member

jhass commented Jun 2, 2016

Let's do this!

@jhass jhass merged commit 93ac92f into master Jun 2, 2016
@asterite asterite deleted the feature/macros_in_lib branch June 2, 2016 19:19
@ysbaddaden
Copy link
Contributor

Yeah! ❤️

@asterite
Copy link
Member Author

asterite commented Jun 2, 2016

Yeah, love it too. Thanks @jhass for the initial proposal!

This isn't just a replacement for ifdef, we can now define multiple similar functions with much less verbosity (for example in lib_llvm), so it's great.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants