Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: rubinius/rubinius
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 28df259b6827
Choose a base ref
...
head repository: rubinius/rubinius
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 531ac3aecb18
Choose a head ref
  • 3 commits
  • 5 files changed
  • 1 contributor

Commits on May 8, 2016

  1. Copy the full SHA
    6a81c5b View commit details
  2. Copy the full SHA
    8f5e2dc View commit details

Commits on May 9, 2016

  1. Copy the full SHA
    531ac3a View commit details
Showing with 3 additions and 50 deletions.
  1. +1 −11 machine/builtin/block_environment.cpp
  2. +0 −6 machine/instructions.def
  3. +1 −23 machine/machine_code.cpp
  4. +0 −5 machine/machine_code.hpp
  5. +1 −5 scripts/deploy.sh
12 changes: 1 addition & 11 deletions machine/builtin/block_environment.cpp
Original file line number Diff line number Diff line change
@@ -383,17 +383,7 @@ namespace rubinius {
return 0;
}

if(mcode->call_count >= 0) {
// TODO: JIT
if(false /*mcode->call_count >= state->shared().config.jit_threshold_compile*/) {
OnStack<1> os(state, env);

G(jit)->compile_soon(state, env->compiled_code(),
invocation.self->direct_class(state), env, true);
} else {
mcode->call_count++;
}
}
mcode->call_count++;

StackVariables* scope = ALLOCA_STACKVARIABLES(mcode->number_of_locals);

6 changes: 0 additions & 6 deletions machine/instructions.def
Original file line number Diff line number Diff line change
@@ -1760,12 +1760,6 @@ section "Miscellaneous. TODO: better categorize these"
instruction check_interrupts() [ -- ]
flush_ip();

// This is used in loops, and allows loops to heat a method up.
if(mcode->call_count >= 0) {
mcode->loop_count++;
mcode->call_count++;
}

state->vm()->checkpoint(state);
end

24 changes: 1 addition & 23 deletions machine/machine_code.cpp
Original file line number Diff line number Diff line change
@@ -59,7 +59,6 @@ namespace rubinius {
, stack_size(code->stack_size()->to_native())
, number_of_locals(code->number_of_locals())
, call_count(0)
, loop_count(0)
, uncommon_count(0)
, _call_site_count_(0)
, _constant_cache_count_(0)
@@ -85,14 +84,6 @@ namespace rubinius {
splat_position = pos->to_native();
}

/* TODO: JIT
// Disable JIT for large methods
if(state->shared().config.jit_disabled ||
total > (size_t)state->shared().config.jit_limit_method_size) {
call_count = -1;
}
*/

for(int i = 0; i < cMaxSpecializations; i++) {
specializations[i].class_data.raw = 0;
specializations[i].execute = 0;
@@ -762,20 +753,7 @@ namespace rubinius {
return NULL;
}

// A negative call_count means we've disabled usage based JIT
// for this method.
if(mcode->call_count >= 0) {
/* TODO: JIT
if(mcode->call_count >= state->shared().config.jit_threshold_compile) {
OnStack<3> os(state, exec, mod, code);
G(jit)->compile_callframe(state, code);
} else {
mcode->call_count++;
}
*/
mcode->call_count++;
}
mcode->call_count++;

Object* value = 0;

5 changes: 0 additions & 5 deletions machine/machine_code.hpp
Original file line number Diff line number Diff line change
@@ -70,7 +70,6 @@ namespace rubinius {
native_int number_of_locals;

native_int call_count;
native_int loop_count;
native_int uncommon_count;

attr_field(call_site_count, size_t);
@@ -140,10 +139,6 @@ namespace rubinius {
flags |= eNoInline;
}

native_int method_call_count() const {
return call_count - loop_count;
}

CallSite* call_site(STATE, int ip);
ConstantCache* constant_cache(STATE, int ip);

6 changes: 1 addition & 5 deletions scripts/deploy.sh
Original file line number Diff line number Diff line change
@@ -352,7 +352,7 @@ EOF

function rbx_deploy_usage {
cat >&2 <<-EOM
Usage: ${0##*/} [release github travis heroku homebrew website docker trigger-heroku trigger-homebrew trigger-travis-osx trigger-travis-12.04 trigger-travis-14.04 triggers]
Usage: ${0##*/} [release github travis heroku homebrew website docker trigger-heroku trigger-homebrew trigger-travis-osx trigger-travis-14.04 triggers]
EOM
exit 1
}
@@ -394,17 +394,13 @@ if [[ "${BASH_SOURCE[0]}" == "${0}" ]]; then
"trigger-travis-osx")
rbx_trigger_deploy "$TRAVIS_OS_NAME" travis-osx
;;
"trigger-travis-12.04")
rbx_trigger_deploy "$TRAVIS_OS_NAME" travis-12.04
;;
"trigger-travis-14.04")
rbx_trigger_deploy "$TRAVIS_OS_NAME" travis-14.04
;;
"triggers")
rbx_trigger_deploy "$TRAVIS_OS_NAME" heroku
rbx_trigger_deploy "$TRAVIS_OS_NAME" homebrew
rbx_trigger_deploy "$TRAVIS_OS_NAME" travis-osx
rbx_trigger_deploy "$TRAVIS_OS_NAME" travis-12.04
rbx_trigger_deploy "$TRAVIS_OS_NAME" travis-14.04
;;
"-h"|"--help"|*)