Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable caching #3893

Merged
merged 1 commit into from
May 17, 2016
Merged

Enable caching #3893

merged 1 commit into from
May 17, 2016

Conversation

BanzaiMan
Copy link
Member

Travis CI has deployed code to take certain extra factors into
consideration when computing cache names.

Our jobs in the build matrix should each receive unique cache names
and we should be able to avoid cache corruption

See a60bd1f

Travis CI has deployed code to take certain extra factors into
consideration when computing cache names.

Our jobs in the build matrix should each receive unique cache names
and we should be able to avoid cache corruption

See a60bd1f
@BanzaiMan
Copy link
Member Author

This was tested on a separate branch.

A build without cache: https://travis-ci.org/jruby/jruby/builds/130709186
The same code (with an empty commit), but with the cache uploaded by the build above: https://travis-ci.org/jruby/jruby/builds/130718600

Some individual job seems to vary a bit, but over all, the saving is about an hour.

One thing to note, though, is that a lot of files are updated in ~/.m2, and we end up uploading the new cache, which adds (perhaps unnecessary) time.

@BanzaiMan
Copy link
Member Author

Not sure how it failed on Appveyor.

@headius
Copy link
Member

headius commented May 17, 2016

The Appveyor build is a wee bit flaky, so I wouldn't worry about that. Thanks, @BanzaiMan!

@headius headius merged commit 7d49df3 into master May 17, 2016
@headius headius deleted the ha-feature-caching branch May 17, 2016 19:53
@eregon
Copy link
Member

eregon commented May 18, 2016

👍

@enebo
Copy link
Member

enebo commented May 18, 2016

Appveyor has never passed with master so that is nothing to worry about. 1.7 is green though. Master will be in the not so distant future.

@enebo enebo modified the milestone: Non-Release May 25, 2016
@Taher-Ghaleb
Copy link

Hello,

Sorry, I know it's been a long time ago, but I am curious why caching hasn't been enabled before this (i.e., since December 17, 2014, when it became available to open source projects).

Thank you.

@headius
Copy link
Member

headius commented Mar 4, 2021

@Taher-Ghaleb It appear that we actually did enable it on December 16, 2014 (12d0ded), but temporarily disabled it again a few months later to investigate some build instability (a60bd1f). The caching feature has evolved over time and there were a few bumps along the way.

This PR just reenabled it again about a year after that.

@Taher-Ghaleb
Copy link

Taher-Ghaleb commented Mar 4, 2021

Thanks, @headius, for your gentle response. I see your point. That answers the questions in my mind.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants