JSON: added root option to mapping, and root argument overload to…
#2648
+104
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| result.to_json.should eq("{}") | ||
| end | ||
|
|
||
| it "parses with nilable root" do |
There was a problem hiding this comment.
This line can be:
it "parses with nilable root and emit null" do
asterite
force-pushed
the
feature/json_root
branch
2 times, most recently
from
fac08c8 to
0f77d95
Compare
… `Object.from_json`. Fixes #2642
jhass
added a commit
that referenced
this pull request
May 25, 2016
JSON: added `root` option to mapping, and `root` argument overload to…
|
❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…
Object.from_json. Fixes #2642A tricky case is root + nilable + emit_null, I think I got it right (but in any case, I don't think it matters much as I'm not sure there are some cases like this in the wild)