-
-
Notifications
You must be signed in to change notification settings - Fork 925
Permalink
Choose a base ref
{{ refName }}
default
Choose a head ref
{{ refName }}
default
Comparing changes
Choose two branches to see what’s changed or to start a new pull request.
If you need to, you can also or
learn more about diff comparisons.
Open a pull request
Create a new pull request by comparing changes across two branches. If you need to, you can also .
Learn more about diff comparisons here.
base repository: jruby/jruby
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: e4fe86db2a42
Could not load branches
Nothing to show
Loading
Could not load tags
Nothing to show
{{ refName }}
default
Loading
...
head repository: jruby/jruby
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 1c5c931900e5
Could not load branches
Nothing to show
Loading
Could not load tags
Nothing to show
{{ refName }}
default
Loading
- 5 commits
- 4 files changed
- 1 contributor
Commits on May 20, 2016
-
Disable the AddLocalVarLoadStore pass to fix #3891.
This was a good experiment, but we're not properly ensuring the heap variables are being loaded live when needed, causing examples like that in #3891 to fail to propagate changes across threads. By implementing LocalVariable load/store logic in JIT and turning off the "Add" pass, we basically revert heap vars to always being read/written immediately, as in JRuby 1.7.25. It may be possible to improve the pass so that it localizes the loads and stores better and ensures we don't miss updates we should see, but this commit will test whether the "nuclear option" passes all our suites.
Configuration menu - View commit details
-
Copy full SHA for cf2df89 - Browse repository at this point
Copy the full SHA cf2df89View commit details -
Fixes to get LocalVariable compiling in all contexts.
Many places just used jvmStoreLocal to store the variable, which assumed (because we only ran with call protocol in place) that all such stores would be to Java locals. I refactored this method to support LocalVariable as well as a different form that avoids stack-juggling to insert the value into the scope. This appears to get almost all code compiling that compiled before.
Configuration menu - View commit details
-
Copy full SHA for 1c183c0 - Browse repository at this point
Copy the full SHA 1c183c0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 88a8896 - Browse repository at this point
Copy the full SHA 88a8896View commit details -
Move OptDelegationPass after OptDynScope so we have temp locals.
We can't store Block in heap scope, so we need this pass to come later.
Configuration menu - View commit details
-
Copy full SHA for 6f37585 - Browse repository at this point
Copy the full SHA 6f37585View commit details
Commits on May 26, 2016
-
Merge pull request #3898 from headius/disable_add_loadstore
Disable the AddLocalVarLoadStore pass to fix #3891.
Configuration menu - View commit details
-
Copy full SHA for 1c5c931 - Browse repository at this point
Copy the full SHA 1c5c931View commit details
There are no files selected for viewing