Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test out MRI's timeout.rb unmodified to fix #3834. #3895

Closed
wants to merge 1 commit into from

Conversation

headius
Copy link
Member

@headius headius commented May 17, 2016

Our native Timeout has not been updated in a long time, and for

  • A separate anonymous exception is not used to trigger the
    timeout anymore; instead, they use catch/throw.
  • The exception message string is pre-allocated and frozen.
  • Various other miscellaneous changes.

This version has not been tested for performance, and it will
initially be much slower than our scheduled executor-based version
due to it always spinning up a timeout thread. But we can see how
it goes in test suites and then evaluate how to move forward.

Note that the change to test/jruby/test_timeout.rb was to bring
behavior in line with MRI 2.3.

Our native Timeout has not been updated in a long time, and for

* A separate anonymous exception is not used to trigger the
  timeout anymore; instead, they use catch/throw.
* The exception message string is pre-allocated and frozen.
* Various other miscellaneous changes.

This version has *not* been tested for performance, and it will
initially be much slower than our scheduled executor-based version
due to it always spinning up a timeout thread. But we can see how
it goes in test suites and then evaluate how to move forward.

Note that the change to test/jruby/test_timeout.rb was to bring
behavior in line with MRI 2.3.
@headius
Copy link
Member Author

headius commented May 20, 2016

Rebased to get a clean build.

@enebo enebo modified the milestones: JRuby 9.1.2.0, JRuby 9.1.3.0 May 25, 2016
@headius
Copy link
Member Author

headius commented Aug 23, 2016

I don't think there's a rush to do this. Let's see about getting timeout.rb updated properly for 9.1.4.0, either moving it back to Ruby or making appropriate adjustments to the native version.

@headius
Copy link
Member Author

headius commented Nov 8, 2016

We can evaluate this along with stdlib updates in 9.2.

@headius headius modified the milestones: JRuby 9.2.0.0, JRuby 9.2.1.0 May 15, 2018
@headius
Copy link
Member Author

headius commented Oct 11, 2018

Kill in favor of #5354.

@headius headius closed this Oct 11, 2018
@headius headius removed this from the JRuby 9.2.1.0 milestone Oct 11, 2018
@headius headius added this to the Invalid or Duplicate milestone Oct 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants