Limit padding width for strftime. #3872
Merged
+11
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://bugs.ruby-lang.org/issues/4456. I'm not certain MRI
has a hard limit in place, but that's the approach I went with.
The original test that started failing (usually timing out) is
from MRI's TestTimeExtension#test_huge_precision:
We attempted to honor that giant padding width blindly, usually
running out of memory or timing out while the GC thrashed.