m-labs · May 13, 2016 · May 13, 2016
Showing with 13 additions and 17 deletions.

+13 −14 artiq/browser/experiments.py

+0 −3 artiq/frontend/artiq_browser.py
diff --git a/artiq/browser/experiments.py b/artiq/browser/experiments.py
@@ -176,7 +176,6 @@ def __init__(self, area, expurl, arguments):
         self.layout.setRowStretch(0, 1)
 
         self.options = {"log_level": logging.WARNING}
-        self._worker = None
         self._run_task = None
 
         log_level = QtWidgets.QComboBox()
@@ -206,6 +205,7 @@ def update_log_level(index):
                           QtWidgets.QSizePolicy.Expanding)
         self.layout.addWidget(run, 1, 4, 2, 1)
         run.clicked.connect(self.run_clicked)
+        self._run = run
 
         terminate = QtWidgets.QPushButton("Terminate")
         terminate.setIcon(QtWidgets.QApplication.style().standardIcon(
@@ -216,6 +216,8 @@ def update_log_level(index):
                                 QtWidgets.QSizePolicy.Expanding)
         self.layout.addWidget(terminate, 3, 4)
         terminate.clicked.connect(self.terminate_clicked)
+        terminate.setEnabled(False)
+        self._terminate = terminate
 
     def dragEnterEvent(self, ev):
         if ev.mimeData().hasFormat("text/uri-list"):
@@ -265,9 +267,6 @@ async def _load_hdf5_task(self, filename):
         await self._recompute_arguments(arguments)
 
     def run_clicked(self):
-        if self._run_task is not None:
-            logger.error("Analysis already started")
-            return
         class_name, file = self.expurl.split("@", maxsplit=1)
         expid = {
             "repo_rev": "N/A",
@@ -280,32 +279,32 @@ def run_clicked(self):
                 for name, argument in self.arguments.items()},
         }
         self._run_task = asyncio.ensure_future(self._get_run_task(expid))
+        self._run.setEnabled(False)
+        self._terminate.setEnabled(True)
 
         def done(fut):
             logger.info("Analysis done")
             self._run_task = None
-
+            self._run.setEnabled(True)
+            self._terminate.setEnabled(False)
         self._run_task.add_done_callback(done)
 
     async def _get_run_task(self, expid):
-        self._worker = Worker(self._area.worker_handlers)
+        worker = Worker(self._area.worker_handlers)
         try:
-            await self._worker.build(rid=None, pipeline_name="browser",
-                                     wd=os.path.abspath("."),
-                                     expid=expid, priority=0)
-            await self._worker.analyze()
+            await worker.build(rid=None, pipeline_name="browser",
+                               wd=os.path.abspath("."),
+                               expid=expid, priority=0)
+            await worker.analyze()
         except:
             # May happen when experiment has been removed
             # from repository/explist
             logger.error("Failed to run '%s'",
                          self.expurl, exc_info=True)
         finally:
-            await self._worker.close()
-            self._worker = None
+            await worker.close()
 
     def terminate_clicked(self):
-        if self._run_task is None:
-            return
         try:
             self._run_task.cancel()
         except:

diff --git a/artiq/frontend/artiq_browser.py b/artiq/frontend/artiq_browser.py
@@ -82,8 +82,6 @@ def main():
     main_window = MainWindow()
     smgr.register(main_window)
     main_window.setUnifiedTitleAndToolBarOnMac(True)
-    status_bar = QtWidgets.QStatusBar()
-    main_window.setStatusBar(status_bar)
 
     mdi_area = experiments.ExperimentsArea(args.browse_root, datasets_sub)
     mdi_area.setHorizontalScrollBarPolicy(QtCore.Qt.ScrollBarAsNeeded)
@@ -114,7 +112,6 @@ def main():
     open_action.setIcon(app.style().standardIcon(
         QtWidgets.QStyle.SP_DialogOpenButton))
     open_action.setShortcuts(QtGui.QKeySequence.Open)
-    open_action.setStatusTip("Open existing experiment from file")
     open_action.triggered.connect(mdi_area.select_experiment)
     toolbar.addAction(open_action)