Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Seafile: service and refactor #15900

Closed
wants to merge 12 commits into from
Closed

Seafile: service and refactor #15900

wants to merge 12 commits into from
+605 −55

Conversation

h2horn
Copy link
Contributor

@h2horn h2horn commented Jun 1, 2016

Motivation for this change

Seafile service, running a full seafile server.

  • To build the seafile server, i had to change the existing seafile-shared package and renamed it to one seafile package.
  • I updated all versions to 5.1.2-server tag, seafile-client (version 5.0.7) builds fine
  • added a bunch of django python packages for seahub

Service file could use some more options:

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • OS X
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

h2horn added 6 commits June 1, 2016 13:59
@h2horn
ccnet: 5.0.7 -> 5.1.2
c7ea021 
- use server release tag, clients build fine
- fix license to gpl2
- use patchShebangs instead of sed
@h2horn
seafile: 5.0.7 -> 5.1.2, init seafile server
5e035eb 
- enable server components
- replaces seafile-shared
- use own version of libevhtp (older version, cmake flags)
@h2horn
seafile-client: fix seafile dependency
da6751a 
- use new seafile package
- delete obsolete seafile-shared
@h2horn
seahub: init 5.1.2
63a941e 
- seafile web frontend and python packages
@h2horn
seafile service: init at 5.1.2
5494432 
- seafile server with seahub
@h2horn
seafile: wrap binaries, fix sandbox build
e0fa63a
@h2horn h2horn changed the title Seafile Seafile: service and refactor Jun 1, 2016
groxxda
groxxda reviewed Jun 1, 2016
View reviewed changes
nixos/modules/services/networking/seafile.nix Outdated
type = types.string;
default = "127.0.0.1";
description = ''
The tcp port used by ccnet.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"port"

@groxxda
Copy link
Contributor

groxxda commented Jun 1, 2016

Just skimmed across the diff. See inline annotations.

joachifm
joachifm reviewed Jun 1, 2016
View reviewed changes
nixos/modules/services/networking/seafile.nix
###### Interface

options.services.seafile = {
enable = mkEnableOption ''
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this will render poorly. The mkEnableOption helper expects simply the name of the service; if you wish to provide a longer form description, you must override it (as in mkEnableOption "foo" // { description = "My long description"; }).

@joachifm joachifm added 0.kind: enhancement Add something new 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: package (new) This PR adds a new package 8.has: package (update) This PR updates a package to a newer version 8.has: module (update) This PR changes an existing module in `nixos/` labels Jun 1, 2016
danbst
danbst reviewed Jun 2, 2016
View reviewed changes
nixos/modules/services/networking/seafile.nix
enable = mkEnableOption ''
Enable Seafile Server.
For further information see [Seafile Manual](http://manual.seafile.com/).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The link should be in docbook style

@FRidh
Copy link
Member

FRidh commented Jun 3, 2016

@Cornu can you make separate commits for each package.
With the Python packages you will most likely have to explicitly disable tests with doCheck = false; because Django packages often don't come with tests, and when they do, they typically don't run out of the box and are hard to set up.

@h2horn
Copy link
Contributor Author

h2horn commented Jun 3, 2016

@FRidh do you mean for each Python package?

I will push new commits this weekend, i'm a little busy right now.

@FRidh
Copy link
Member

FRidh commented Jun 27, 2016

Indeed, for each Python package.

@FRidh FRidh added the 2.status: work-in-progress This PR isn't done label Jun 27, 2016
@kampfschlaefer
seafile: Start a test
30bb7c5 
Start with a test to proof the seafile-server module works.

Also fix the first errors shown by the test.
@kampfschlaefer
seafile: 5.1.2 -> 5.1.4
4299e92 
The tests show that 5.1.2 has an error in seaf-cli which is fixed in the
latest 5.1.x version.
@kampfschlaefer
Copy link
Contributor

I started writing a test for this module in h2horn#1

@kampfschlaefer
seafile: run seahub-fcgi on private address
e1f6650 
It is meant to be run behind an nginx proxy.
@kampfschlaefer
seafile: typo fix
788a310
@kampfschlaefer
seafile-test: Test with nginx-proxy and two clients
9b93150 
Extend the tests:
- nginx as proxy before the seahub-fcgi
- one client to create a library and place a file in it
- second client to download that library and check the file in it
@uwap
Copy link
Contributor

uwap commented Mar 1, 2017

@Cornu Any updates on this?

@h2horn
Copy link
Contributor Author

h2horn commented Mar 16, 2017

@uwap Hey, i'm not running seafile at the moment, so won't work on this anytime soon.
I would however merge pull requests and help with improvements, so feel free to help.

@kampfschlaefer Thanks for the module test

So open issues are:

  • update to current version of seafile
  • split python packages into seperate commits

@jeaye
Copy link
Contributor

jeaye commented Aug 20, 2017

Having a Seafile service in NixOS would be superb; thanks for this work!

@infinisil
Copy link
Member

Closing this for now, doesn't look like this will get finished anytime soon.

@infinisil infinisil closed this Aug 2, 2018
@greizgh greizgh mentioned this pull request Apr 17, 2021
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
0.kind: enhancement Add something new 2.status: work-in-progress This PR isn't done 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 8.has: package (new) This PR adds a new package 8.has: package (update) This PR updates a package to a newer version
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
9 participants
@h2horn @groxxda @FRidh @kampfschlaefer @uwap @jeaye @infinisil @joachifm @danbst