Seafile: service and refactor #15900

h2horn · 2016-06-01T15:06:52Z

Motivation for this change

Seafile service, running a full seafile server.

To build the seafile server, i had to change the existing seafile-shared package and renamed it to one seafile package.
I updated all versions to 5.1.2-server tag, seafile-client (version 5.0.7) builds fine
added a bunch of django python packages for seahub

Service file could use some more options:

all databases are sqlite (seafile defaults)
configured to run in fastcgi mode behind Nginx/Apache (see http://manual.seafile.com/deploy/deploy_with_nginx.html)

Things done

Tested using sandboxing
(nix.useSandbox on NixOS,
or option build-use-sandbox in nix.conf
on non-NixOS)
Built on platform(s)
- NixOS
- OS X
- Linux
Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
Tested execution of all binary files (usually in ./result/bin/)
Fits CONTRIBUTING.md.

- use server release tag, clients build fine - fix license to gpl2 - use patchShebangs instead of sed

- enable server components - replaces seafile-shared - use own version of libevhtp (older version, cmake flags)

- use new seafile package - delete obsolete seafile-shared

- seafile web frontend and python packages

- seafile server with seahub

groxxda · 2016-06-01T19:55:51Z

nixos/modules/services/networking/seafile.nix

+      type = types.string;
+      default = "127.0.0.1";
+      description = ''
+        The tcp port used by ccnet.


groxxda · 2016-06-01T20:10:04Z

Just skimmed across the diff. See inline annotations.

joachifm · 2016-06-01T22:38:47Z

nixos/modules/services/networking/seafile.nix

+  ###### Interface
+
+  options.services.seafile = {
+    enable = mkEnableOption ''


I believe this will render poorly. The mkEnableOption helper expects simply the name of the service; if you wish to provide a longer form description, you must override it (as in mkEnableOption "foo" // { description = "My long description"; }).

danbst · 2016-06-02T05:37:46Z

nixos/modules/services/networking/seafile.nix

+    enable = mkEnableOption ''
+      Enable Seafile Server.
+
+      For further information see [Seafile Manual](http://manual.seafile.com/).


The link should be in docbook style

FRidh · 2016-06-03T08:37:28Z

@Cornu can you make separate commits for each package.
With the Python packages you will most likely have to explicitly disable tests with doCheck = false; because Django packages often don't come with tests, and when they do, they typically don't run out of the box and are hard to set up.

h2horn · 2016-06-03T08:58:10Z

@FRidh do you mean for each Python package?

I will push new commits this weekend, i'm a little busy right now.

FRidh · 2016-06-27T12:02:40Z

Indeed, for each Python package.

Start with a test to proof the seafile-server module works. Also fix the first errors shown by the test.

The tests show that 5.1.2 has an error in seaf-cli which is fixed in the latest 5.1.x version.

kampfschlaefer · 2016-08-20T15:26:50Z

I started writing a test for this module in h2horn#1

It is meant to be run behind an nginx proxy.

Extend the tests: - nginx as proxy before the seahub-fcgi - one client to create a library and place a file in it - second client to download that library and check the file in it

uwap · 2017-03-01T16:38:11Z

@Cornu Any updates on this?

Add test for seafile-module

h2horn · 2017-03-16T08:41:52Z

@uwap Hey, i'm not running seafile at the moment, so won't work on this anytime soon.
I would however merge pull requests and help with improvements, so feel free to help.

@kampfschlaefer Thanks for the module test

So open issues are:

update to current version of seafile
split python packages into seperate commits

jeaye · 2017-08-20T01:27:31Z

Having a Seafile service in NixOS would be superb; thanks for this work!

infinisil · 2018-08-02T22:30:51Z

Closing this for now, doesn't look like this will get finished anytime soon.

h2horn added 6 commits June 1, 2016 13:59

ccnet: 5.0.7 -> 5.1.2

c7ea021

- use server release tag, clients build fine - fix license to gpl2 - use patchShebangs instead of sed

seafile: 5.0.7 -> 5.1.2, init seafile server

5e035eb

- enable server components - replaces seafile-shared - use own version of libevhtp (older version, cmake flags)

seafile-client: fix seafile dependency

da6751a

- use new seafile package - delete obsolete seafile-shared

seahub: init 5.1.2

63a941e

- seafile web frontend and python packages

seafile service: init at 5.1.2

5494432

- seafile server with seahub

seafile: wrap binaries, fix sandbox build

e0fa63a

h2horn changed the title ~~Seafile~~ Seafile: service and refactor Jun 1, 2016

groxxda reviewed Jun 1, 2016
View reviewed changes

joachifm reviewed Jun 1, 2016
View reviewed changes

joachifm added 0.kind: enhancement 6.topic: nixos 8.has: package (new) 8.has: package (update) 8.has: module (update) labels Jun 1, 2016

danbst reviewed Jun 2, 2016
View reviewed changes

FRidh added the 2.status: work-in-progress label Jun 27, 2016

kampfschlaefer added 2 commits August 20, 2016 17:16

seafile: Start a test

30bb7c5

Start with a test to proof the seafile-server module works. Also fix the first errors shown by the test.

seafile: 5.1.2 -> 5.1.4

4299e92

The tests show that 5.1.2 has an error in seaf-cli which is fixed in the latest 5.1.x version.

kampfschlaefer added 3 commits August 21, 2016 13:17

seafile: run seahub-fcgi on private address

e1f6650

It is meant to be run behind an nginx proxy.

seafile: typo fix

788a310

seafile-test: Test with nginx-proxy and two clients

9b93150

Extend the tests: - nginx as proxy before the seahub-fcgi - one client to create a library and place a file in it - second client to download that library and check the file in it

Merge pull request #1 from kampfschlaefer/cornu-seafile

c64b67c

Add test for seafile-module

infinisil closed this Aug 2, 2018

greizgh mentioned this pull request Apr 17, 2021

nixos/seafile: init service #119719

Merged

10 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Seafile: service and refactor #15900

Seafile: service and refactor #15900

h2horn commented Jun 1, 2016

groxxda Jun 1, 2016

groxxda commented Jun 1, 2016

joachifm Jun 1, 2016

danbst Jun 2, 2016

FRidh commented Jun 3, 2016

h2horn commented Jun 3, 2016

FRidh commented Jun 27, 2016

kampfschlaefer commented Aug 20, 2016

uwap commented Mar 1, 2017

h2horn commented Mar 16, 2017

jeaye commented Aug 20, 2017

infinisil commented Aug 2, 2018

Seafile: service and refactor #15900

Seafile: service and refactor #15900

Conversation

h2horn commented Jun 1, 2016

Motivation for this change

Things done

groxxda Jun 1, 2016

Choose a reason for hiding this comment

groxxda commented Jun 1, 2016

joachifm Jun 1, 2016

Choose a reason for hiding this comment

danbst Jun 2, 2016

Choose a reason for hiding this comment

FRidh commented Jun 3, 2016

h2horn commented Jun 3, 2016

FRidh commented Jun 27, 2016

kampfschlaefer commented Aug 20, 2016

uwap commented Mar 1, 2017

h2horn commented Mar 16, 2017

jeaye commented Aug 20, 2017

infinisil commented Aug 2, 2018