Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort prelude.cr #2654

Merged
merged 1 commit into from
Jun 2, 2016
Merged

Conversation

miketheman
Copy link
Contributor

Add comments as to why order usually doesn't matter here.

Ref: #2649 (comment)

Add comments as to why order usually doesn't matter here.
@asterite
Copy link
Member

I'm not sure this should be placed in a comment, but rather in the language docs (that order doesn't matter much, and how the compiler works)

@miketheman
Copy link
Contributor Author

miketheman commented May 26, 2016

@asterite The comment is here for anyone else adding to this file - they shouldn't have to read the docs to know where to place the correct entry.

I don't think I'm qualified to document how the compiler works yet. :)

@jhass
Copy link
Member

jhass commented Jun 1, 2016

I agree that the comment is good here and that the change in general is good. It's specific to the compiler, a more general description should go to the language docs at the same time.

@asterite how strong do you feel abou this?

@asterite
Copy link
Member

asterite commented Jun 1, 2016

I think it's OK as it helps anyone wanting to add something to prelude. I'd also include a note to remember to add it to docs_main so it appears in the docs. But just that.

@asterite
Copy link
Member

asterite commented Jun 2, 2016

Let's merge this. I'll then add a reference to docs_main.

@asterite asterite merged commit 4d9ee07 into crystal-lang:master Jun 2, 2016
@miketheman miketheman deleted the miketheman/prelude branch August 6, 2017 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants