Patch/11 may16 #202
Closed
Patch/11 may16 #202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I will look at it this weekend latest... |
|
No rush |
…Here we simply store a visit map and only bend/stretch a bond if it's the first pair it's seen in.
…epresentation, for example (H2O)8.
|
Rebased to stop Travis moaning. |
|
Yeah, never tell me "no rush"... too much other things will interfere then, and then I won't get to it :/ |
| @@ -556,6 +557,13 @@ private double bend(AtomPair pair, IntStack stack, Point2d[] coords) { | |||
| for (IBond bond : pair.bndAt) { | |||
| if (bond.isInRing()) continue; | |||
|
|
|||
| // has this bond already been tested as part of another pair | |||
| AtomPair first = firstVisit.get(bond); | |||
There was a problem hiding this comment.
Possible NPE source? It's a private method, so probably not...
There was a problem hiding this comment.
Yep - If public would check the params at top of method.
|
Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some misc patches... on rendering of course!