Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix test profile #978

Closed
BanzaiMan opened this issue Aug 29, 2013 · 6 comments
Closed

Fix test profile #978

BanzaiMan opened this issue Aug 29, 2013 · 6 comments
Milestone

Comments

@BanzaiMan
Copy link
Member

It has been a while since we moved to maven, but the main 'test-extended' target that Travis runs have never been completely fixed.

This is the last successful build with the old 'ant' way (ant test-extended): https://travis-ci.org/jruby/jruby/jobs/8438749

And this is the first failure with the new 'mvn' way (mvn -q -Ptest test): https://travis-ci.org/jruby/jruby/jobs/8685411

Not exactly sure how the things changed and broke, but these should be fixed.

@ghost ghost assigned mkristian Aug 29, 2013
@BanzaiMan
Copy link
Member Author

I've fixed a few of the outstanding tests with ee734a2.

The remaining cases are:

Failed tests:
  ScriptingContainerTest.testRunScriptlet_PathType_String:844 expected:<[ウラン >> プルトニウム >> 炭素 >> ラジウム >> アインスタイニウム >> ノーベリウム: 6 in total]> but was:<[]>
  ScriptingContainerTest.testGetCompileMode:1755 expected:<JIT> but was:<OFF>
  ScriptingContainerTest.testSetCompatVersion:1862 expected:<bear> but was:<null>
  ScriptingContainerTest.testSetClassLoader:2116 Null classloader provided for ClassCache

Tests in error:
  ReaderInputStreamTest.testRead_3args_bigfile:218 » EvalFailed (LoadError) no s...
  JRubyEngineTest.testPathTyp:330 » BSF (NoMethodError) undefined method `amount...
  JRubyEngineTest.testRubyVersion:342 NullPointer
  ScriptingContainerTest.testParse_3args_2:612 NullPointer
  ScriptingContainerTest.testRunScriptlet_InputStream_String:780 NullPointer
  ScriptingContainerTest.testCallMethod_3args:921 » InvokeFailed (NoMethodError)...
  ScriptingContainerTest.testCallMethod_4args_1:969 » InvokeFailed (NoMethodErro...
  ScriptingContainerTest.testCallMethod_4args_2:1000 » InvokeFailed (NoMethodErr...
  ScriptingContainerTest.testCallMethod_4args_3:1071 NullPointer
  ScriptingContainerTest.testGetInstance » Raise (NoMethodError) undefined metho...

Tests run: 365, Failures: 4, Errors: 10, Skipped: 0

@BanzaiMan
Copy link
Member Author

https://travis-ci.org/jruby/jruby/jobs/10825790#L167 seems to creep up from time to time.

@jvbreen1
Copy link

@BanzaiMan is this an intermittent issue? I can't seem to reproduce:

Running org.jruby.embed.ScriptingContainerTest
Tests run: 84, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 11.954 sec - in org.jruby.embed.ScriptingContainerTest
Running org.jruby.embed.ReaderInputStreamTest
Tests run: 10, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.079 sec - in org.jruby.embed.ReaderInputStreamTest

@kares
Copy link
Member

kares commented Feb 26, 2016

@jvbreen1 feel free to fire up a PR where you revert the changes against a green master and we'll see :)

@jvbreen1
Copy link

jvbreen1 commented Mar 2, 2016

@kares I'm not sure I understand. I thought the issue was fixed. Are you suggesting I revert the change in order to reproduce the issue and thus verify the fix?

@headius headius added this to the JRuby 9.0.0.0 milestone May 11, 2016
@headius
Copy link
Member

headius commented May 11, 2016

Fixed long ago, before 9k release.

@headius headius closed this as completed May 11, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants