Skip to content

Commit

Permalink
Showing 4 changed files with 1 addition and 24 deletions.
Original file line number Diff line number Diff line change
@@ -154,7 +154,7 @@ private static void addMethod(RubyContext context, DynamicObject module, RubyRoo
private static RubyRootNode makeGenericMethod(RubyContext context, MethodDetails methodDetails) {
final CoreMethod method = methodDetails.getMethodAnnotation();

final SourceSection sourceSection = CoreSourceSection.createCoreSourceSection(methodDetails.getClassAnnotation().value(), method.names()[0]);
final SourceSection sourceSection = SourceSection.createUnavailable(null, String.format("%s#%s", methodDetails.getClassAnnotation().value(), method.names()[0]));

This comment has been minimized.

Copy link
@eregon

eregon May 10, 2016

Member

kind could be core here or builtin.

This comment has been minimized.

Copy link
@chrisseaton

chrisseaton May 10, 2016

Author Contributor

Does anyone ever use kind? I'm trying to simplify the features of source section we use to work out what is really useful and inform a redesign of the API with @mlvdv

This comment has been minimized.

Copy link
@eregon

eregon May 10, 2016

Member

It appears in TraceTruffleCompilation output AFAIK, which might be useful to easily differentiate methods implemented in Ruby or Java.


final int required = method.required();
final int optional = method.optional();

This file was deleted.

2 changes: 0 additions & 2 deletions truffle/src/main/java/org/jruby/truffle/core/CoreLibrary.java
Original file line number Diff line number Diff line change
@@ -18,7 +18,6 @@
import com.oracle.truffle.api.object.DynamicObjectFactory;
import com.oracle.truffle.api.object.Layout;
import com.oracle.truffle.api.object.Property;
import com.oracle.truffle.api.source.SourceSection;
import jnr.constants.platform.Errno;
import org.jcodings.EncodingDB;
import org.jcodings.specific.UTF8Encoding;
@@ -31,7 +30,6 @@
import org.jruby.truffle.Layouts;
import org.jruby.truffle.RubyContext;
import org.jruby.truffle.builtins.CoreMethodNodeManager;
import org.jruby.truffle.builtins.CoreSourceSection;
import org.jruby.truffle.core.array.ArrayNodes;
import org.jruby.truffle.core.array.ArrayNodesFactory;
import org.jruby.truffle.core.basicobject.BasicObjectNodesFactory;
Original file line number Diff line number Diff line change
@@ -37,7 +37,6 @@
import org.jruby.truffle.builtins.CoreMethod;
import org.jruby.truffle.builtins.CoreMethodArrayArgumentsNode;
import org.jruby.truffle.builtins.CoreMethodNode;
import org.jruby.truffle.builtins.CoreSourceSection;
import org.jruby.truffle.builtins.Primitive;
import org.jruby.truffle.builtins.PrimitiveArrayArgumentsNode;
import org.jruby.truffle.builtins.YieldingCoreMethodNode;

0 comments on commit 5f63605

Please sign in to comment.