Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

darwin: fixed gnulib in libpipeline and man-db #15883

Closed
wants to merge 1 commit into from
Closed

darwin: fixed gnulib in libpipeline and man-db #15883

wants to merge 1 commit into from

Conversation

LnL7
Copy link
Member

@LnL7 LnL7 commented May 31, 2016 •
edited

Motivation for this change

Partial fixes for #15849
These changes fix gnulib for both libpipeline and man-db, however there is still an issue with the man-db package:

Undefined symbols for architecture x86_64:
  "_database", referenced from:
      _gripe_corrupt_data in libmandb_la-db_lookup.o
      _gripe_replace_key in libmandb_la-db_lookup.o
      _split_content in libmandb_la-db_lookup.o
      _dblookup in libmandb_la-db_lookup.o
      _dblookup_pattern in libmandb_la-db_lookup.o
      _dbver_rd in libmandb_la-db_ver.o
      _dbver_wr in libmandb_la-db_ver.o
      ...
Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • OS X
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@LnL7 LnL7 changed the title [WIP] darwin: fixed gnulib in libpipeline and man-db darwin: fixed gnulib in libpipeline and man-db May 31, 2016
@copumpkin
Copy link
Member

Are the two .patch files identical? Perhaps they could live in the gnulib folder? Otherwise this seems good.

@joachifm joachifm added the 6.topic: darwin Running or building packages on Darwin label Jun 7, 2016
@LnL7
Copy link
Member Author

LnL7 commented Jun 8, 2016

@copumpkin looks like the missing _database symbol is only is only used in libdb/db_lookup.c and libdb/db_ver.c for debugging purposes.
I guess it might be ok just to replace those with an empty string.

@vcunat
Copy link
Member

vcunat commented Aug 29, 2016

Ping? The issue #15849 is marked as blocker...

@LnL7
Copy link
Member Author

LnL7 commented Aug 29, 2016

The man package works because it was switched back to man-old on darwin. I have not looked at this further, but like I do have a possible fix like I said before.

@Ekleog
Copy link
Member

Ekleog commented Mar 26, 2019

(triage) @LnL7 Is this still relevant? I feel like it should be closed due to old age, but without any kind of certainty.

@LnL7
Copy link
Member Author

LnL7 commented Mar 26, 2019

Yeah, this is pretty old. I should try it again.

@LnL7 LnL7 closed this Mar 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@LnL7 @copumpkin @vcunat @Ekleog @joachifm