-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docker: Preinstall git in released docker image #2620
Conversation
Why not in both? |
Is |
I don't even know what the release image is really used for, but I imagine similar things for both. |
I'm trying to use the release image (built by I suppose that the Just guessing... 8-) |
The official release packages are built from crystal-lang/omnibus-crystal. Travis CI support uses the debian packages built by omnibus, as well as the nightly packages built by my fork of the omnibus project. Crystals own Travis CI setup uses the images from jhass/crystal-build-docker. |
@jhass Thank you for the explanations! Last question, how are images on docker.io built? Running
Running
My conclusion, I hope I'm right %-) |
@splattael That's exactly right. I think |
This is a follow-up to 4f7d5bc which installed git only in "head" docker image. This commit adds git also to the release docker images.
Thanks! |
💚 |
This is a fix for 4f7d5bc which installed git in the wrong image (head).
See #2615