Add regular {op}over equivalent names #185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The operations in Ufunc along a dimension are mostly named something ending in -over like 'sumover', except for the cases of routines with names including average, minimum, and maximum. This was a cute but surprising set of special cases. Adding this following equivalent routines: average -> avgover daverage -> davgover maximum -> maxover maximum_ind -> maxover_ind maximum_n_ind -> maxover_n_ind minmaximum -> minmaxover minimum -> minover minimum_ind -> minover_ind minimum_n_ind -> minover_n_ind
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The operations in Ufunc along a dimension are mostly named
something ending in -over like 'sumover', except for the
cases of routines with names including average, minimum, and
maximum. This was a cute but surprising set of special cases.
Adding this following equivalent routines:
average -> avgover
daverage -> davgover
maximum -> maxover
maximum_ind -> maxover_ind
maximum_n_ind -> maxover_n_ind
minmaximum -> minmaxover
minimum -> minover
minimum_ind -> minover_ind
minimum_n_ind -> minover_n_ind