Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: jruby/jruby
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 54c031b98437
Choose a base ref
...
head repository: jruby/jruby
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 3b26bc71ad85
Choose a head ref

Commits on May 20, 2016

  1. Disable the AddLocalVarLoadStore pass to fix #3891.

    This was a good experiment, but we're not properly ensuring the
    heap variables are being loaded live when needed, causing examples
    like that in #3891 to fail to propagate changes across threads.
    By implementing LocalVariable load/store logic in JIT and turning
    off the "Add" pass, we basically revert heap vars to always being
    read/written immediately, as in JRuby 1.7.25.
    
    It may be possible to improve the pass so that it localizes the
    loads and stores better and ensures we don't miss updates we
    should see, but this commit will test whether the "nuclear option"
    passes all our suites.
    headius committed May 20, 2016
    Copy the full SHA
    cf2df89 View commit details
  2. Fixes to get LocalVariable compiling in all contexts.

    Many places just used jvmStoreLocal to store the variable, which
    assumed (because we only ran with call protocol in place) that
    all such stores would be to Java locals. I refactored this method
    to support LocalVariable as well as a different form that avoids
    stack-juggling to insert the value into the scope. This appears to
    get almost all code compiling that compiled before.
    headius committed May 20, 2016
    Copy the full SHA
    1c183c0 View commit details
  3. Copy the full SHA
    88a8896 View commit details
  4. Move OptDelegationPass after OptDynScope so we have temp locals.

    We can't store Block in heap scope, so we need this pass to come
    later.
    headius committed May 20, 2016
    Copy the full SHA
    6f37585 View commit details
  5. Copy the full SHA
    d4d6ac3 View commit details
  6. Unify super and call splatting logic in interpreter and JIT.

    This improves things in a few ways:
    
    * JIT and interpreter are calling through most of the same APIs.
    * Fewer transient objects for calls with splats.
    * Less duplication of code.
    
    There are other ways we could split the super dispatch paths
    apart to reduce overhead and allocation. This patch puts us on
    that path.
    headius committed May 20, 2016
    Copy the full SHA
    32512d5 View commit details

Commits on May 22, 2016

  1. Copy the full SHA
    47a9386 View commit details
  2. Copy the full SHA
    8847b78 View commit details

Commits on May 26, 2016

  1. Copy the full SHA
    aa425d6 View commit details
  2. wait_readable in MRI appears to always block, so we should too.

    This may have been an oversight; 0 means don't wait on the select
    at all, but I may have been confused thinking it meant wait
    forever. Doing waitReadable but not waiting for it to be readable
    seems obviously wrong.
    headius committed May 26, 2016
    Copy the full SHA
    f4d66bd View commit details
  3. Merge pull request #3898 from headius/disable_add_loadstore

    Disable the AddLocalVarLoadStore pass to fix #3891.
    headius committed May 26, 2016
    Copy the full SHA
    1c5c931 View commit details
  4. Merge pull request #3909 from headius/zsuper_sans_binding

    ZSuper does not require caller's binding/scope.
    headius committed May 26, 2016
    Copy the full SHA
    6d1062e View commit details
  5. Merge pull request #3912 from MSNexploder/string_tests

    fix four additional MRI string tests
    headius committed May 26, 2016
    Copy the full SHA
    4d9c129 View commit details
  6. Merge pull request #3911 from headius/zsuper_splatmap

    Unify super and call splatting logic in interpreter and JIT.
    headius committed May 26, 2016
    Copy the full SHA
    276a7d2 View commit details
  7. Merge pull request #3929 from headius/waitreadable_blocking

    waitReadable should block
    headius committed May 26, 2016
    Copy the full SHA
    a65ad3a View commit details
  8. Copy the full SHA
    8b73005 View commit details
  9. Use special Maven local repository dir to isolate in parallel running…

    … mx builds
    Jaroslav Tulach committed May 26, 2016
    Copy the full SHA
    26a4fca View commit details
  10. Copy the full SHA
    6dbf62c View commit details
  11. Copy the full SHA
    23b13fc View commit details
  12. Copy the full SHA
    ae90ed6 View commit details
  13. Copy the full SHA
    5115b11 View commit details
  14. Copy the full SHA
    01a69f0 View commit details
  15. Using maven_version_arg and maven_repo_arg instead of repeating the s…

    …trings
    Jaroslav Tulach committed May 26, 2016
    Copy the full SHA
    cbc6e91 View commit details
  16. Removing commented out code

    Jaroslav Tulach committed May 26, 2016
    Copy the full SHA
    e02a08f View commit details
  17. Merge pull request #3931 from jtulach/MavenRepo

    [Truffle] Use private maven repo instead of $HOME/.m2
    eregon committed May 26, 2016
    Copy the full SHA
    64ba959 View commit details
  18. [Truffle] reset buffer before reopening

    otherwise reopend io will inherit unclean buffer
    pitr-ch committed May 26, 2016
    Copy the full SHA
    9b255cf View commit details
  19. Copy the full SHA
    e73f65e View commit details
  20. Copy the full SHA
    86aebed View commit details
  21. Copy the full SHA
    bbb5009 View commit details
  22. Copy the full SHA
    05effd1 View commit details
  23. Copy the full SHA
    a48d113 View commit details
  24. Copy the full SHA
    75e7a35 View commit details
  25. Copy the full SHA
    5d8f696 View commit details
  26. Copy the full SHA
    bb6a444 View commit details
  27. Copy the full SHA
    6a75d7a View commit details
  28. Copy the full SHA
    78d2436 View commit details
  29. Copy the full SHA
    ab63a40 View commit details
  30. Copy the full SHA
    251f680 View commit details
  31. Copy the full SHA
    d472e99 View commit details
  32. Copy the full SHA
    72fdffe View commit details
  33. Copy the full SHA
    3b26bc7 View commit details
Loading