LLVM intrinsics refactor, adding bitswap. #2691
Conversation
Changes: * `::Intrinsics` lib changed to module * split by topic, i.e. `Intrinsics::BitManipulation` * separate llvm api (explicit, 1-1 naming etc.) from crystal api (overloading, crystal names etc.) * added bit swapping (should it be called `flip` or something else instead of `bswap`?) The rationale behind separating into topic modules is that there are a lot of intrinsic functions and that's how they are documented at http://llvm.org/docs/LangRef.html#llvm-readcyclecounter-intrinsic. Separation between llvm and crystal apis means that you can look up llvm docs and know what the function does and crystal functions are... well, crystallised with overloading for crystal types, our documentation etc.
|
The Intrinsics lib is there to be used by the standard library to implement some basic operations. It's not intended to be used outside the standard library's implementation (because the standard library provides wrappers for that functionality). As you can see, all the Intrinsics functions are used inside other types, such as I also usually don't like having mini-modules and then include them in a bigger module, it makes things harder to look up, and it probably increases compile times (but this is just a personal opinion). I'll close this. But next time please open an issue, I don't like closing PR but it's better to discuss things first before jumping into an implementation/change. |
Changes:
::Intrinsicslib changed to moduleIntrinsics::BitManipulation(overloading, crystal names etc.)
flipor something elseinstead of
bswap?)The rationale behind separating into topic modules is that there are a
lot of intrinsic functions and that's how they are documented at
http://llvm.org/docs/LangRef.html#llvm-readcyclecounter-intrinsic.
Separation between llvm and crystal apis means that you can look up llvm
docs and know what the function does and crystal functions are... well,
crystallised with overloading for crystal types, our documentation etc.