Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Soften this restriction to just readable resources. #3902

Merged
merged 1 commit into from
May 26, 2016

Conversation

headius
Copy link
Member

@headius headius commented May 18, 2016

Additional fix for issue exposed by #3901. Devices, like ttys,
pipes, fifos and the like may be neither file nor symlink, but
still readable as script source. The restriction here is
unnecessary.

Ping @mkristian... I softened this test but I'm not sure why it was so restrictive in the first place. Is this change ok?

Additional fix for issue exposed by jruby#3901. Devices, like ttys,
pipes, fifos and the like may be neither file nor symlink, but
still readable as script source. The restriction here is
unnecessary.
@mkristian
Copy link
Member

@headius looks ok to me. do not remember the details, but was something like a directory path as resource.

@danini-the-panini
Copy link
Contributor

@headius @mkristian I have tested with a directory, it passes canRead and then throws at inputStream. See #4100

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants