Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Truffle] Use private maven repo instead of $HOME/.m2 #3931

Merged
merged 4 commits into from
May 26, 2016
Merged

[Truffle] Use private maven repo instead of $HOME/.m2 #3931

merged 4 commits into from
May 26, 2016

Conversation

jtulach
Copy link
Contributor

@jtulach jtulach commented May 26, 2016

I need to use local repository when building JRuby, otherwise parallel builds accessing $HOME/.m2 influence each other and cause random failures.

This change depends on mx changeset jtulach/mx@9944309 named "Add --repo parameter to mx maven-install to control where to install the JARs to".

mx.run(['find', '.'], nonZeroIsFatal=False, cwd=rubyDir)
mx.run_maven(['--version'], nonZeroIsFatal=False, cwd=rubyDir)
#mx.run(['find', '.'], nonZeroIsFatal=False, cwd=rubyDir)
mx.run_maven(['--version', '-Dmaven.repo.local=' + mavenDir], nonZeroIsFatal=False, cwd=rubyDir)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be saved in a local variable, similar to the mx patch.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure what you mean...

@jtulach
Copy link
Contributor Author

jtulach commented May 26, 2016

The necessary mx commit is in - you can merge once you feel the change is OK.

@eregon
Copy link
Member

eregon commented May 26, 2016

Looks great now, thanks!

@eregon eregon merged commit 64ba959 into jruby:master May 26, 2016
@enebo enebo modified the milestone: truffle-dev Aug 26, 2016
@enebo enebo added this to the Non-Release milestone Dec 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants