Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #1856 -- make tag listing pages per-language #1861

Merged
merged 6 commits into from Jul 4, 2015
Merged

Fix #1856 -- make tag listing pages per-language #1861

merged 6 commits into from Jul 4, 2015

Conversation

Kwpolska
Copy link
Member

@Kwpolska Kwpolska commented Jul 4, 2015

This change will display only tags that exist in this language’s posts, honoring SHOW_UNTRANSLATED_POSTS. However, the current behavior of per-tag pages is retained to help people who jump between languages by changing URLs.

cc @teknico

Review on Reviewable

@Kwpolska
Fix #1856 -- make tag listing pages per-language
ca6a18a 
Signed-off-by: Chris Warrick <kwpolska@gmail.com>
@Kwpolska
continuation line under-indented for visual indent
1703e6d 
Signed-off-by: Chris Warrick <kwpolska@gmail.com>
@Kwpolska
Handle untranslated posts’ tags correctly (Issue #1856)
4d88a78 
Signed-off-by: Chris Warrick <kwpolska@gmail.com>
@Kwpolska
Write changelog entry for issue #1856
8199242 
Signed-off-by: Chris Warrick <kwpolska@gmail.com>
@Kwpolska Kwpolska added this to the v7.6.1 milestone Jul 4, 2015
@Kwpolska
Add coverage exceptions
de42cfb 
Signed-off-by: Chris Warrick <kwpolska@gmail.com>
@Kwpolska
Fix omissions?
bc2a3ae 
Signed-off-by: Chris Warrick <kwpolska@gmail.com>
@teknico
Copy link

teknico commented Jul 4, 2015

Tested and it works exactly as I hoped, thanks a lot!

Brown paper bag moment: can you please resync the Italian translation from Transifex? I botched a pretty important term ("English" -> "Italiano"), fixed now.

Regarding "the current behavior of per-tag pages", pages of tags in all languages are accessible by URLs in all languages (not only their own), is that what you meant? That's fine by me.

@Kwpolska
Copy link
Member Author

Kwpolska commented Jul 4, 2015

Brown paper bag moment: can you please resync the Italian translation from Transifex? I botched a pretty important term ("English" -> "Italiano"), fixed now.

That would normally be done on release, but I’ll handle it now.

Regarding "the current behavior of per-tag pages", pages of tags in all languages are accessible by URLs in all languages (not only their own), is that what you meant? That's fine by me.

Yup.

Kwpolska added a commit that referenced this pull request Jul 4, 2015
@Kwpolska
Merge pull request #1861 from getnikola/per-language-tags
d498e68 
Fix #1856 -- make tag listing pages per-language
@Kwpolska Kwpolska merged commit d498e68 into master Jul 4, 2015
@Kwpolska Kwpolska deleted the per-language-tags branch July 4, 2015 18:38
@teknico
Copy link

teknico commented Jul 4, 2015

That would normally be done on release, but I’ll handle it now.

Unfortunately the v.7.6.0 release happened in the meantime, and its Italian translation is similarly botched. I apologize. :-(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug i18n
Projects
None yet
Milestone
v7.6.1
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Kwpolska @teknico